Review RELEASE_OR_BETA checks in gfxFont.cpp

RESOLVED FIXED in Firefox 68

Status

()

task
P3
normal
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: RyanVM, Assigned: jfkthame)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

gfxFont.cpp has code which was disabled for non-Nightly builds due to crashes tracked in bug 717175 and bug 894798:
https://searchfox.org/mozilla-central/source/gfx/thebes/gfxFont.cpp#185

From what I can see, there's been 3 crashes with the gfxFontCache::WordCacheExpirationTimerCallback signature from bug 894798 in the last 6 months. Is it worth revisiting this block?

There's also a few other RELEASE_OR_BETA checks in gfxFont.cpp - not sure if those are ones we need or not either.

(In reply to Ryan VanderMeulen [:RyanVM] from comment #0)

gfxFont.cpp has code which was disabled for non-Nightly builds due to crashes tracked in bug 717175 and bug 894798:
https://searchfox.org/mozilla-central/source/gfx/thebes/gfxFont.cpp#185

From what I can see, there's been 3 crashes with the gfxFontCache::WordCacheExpirationTimerCallback signature from bug 894798 in the last 6 months. Is it worth revisiting this block?

In principle, it would be beneficial to enable this code, but it's unclear to me whether the underlying problem is still present, as we never really got to the bottom of it.

I'd suggest we try changing the conditional there to be #ifdef EARLY_BETA_OR_EARLIER, so as to get more extensive testing of the code in question, and see what crash-stats look like after that's had some time in the wild.

There's also a few other RELEASE_OR_BETA checks in gfxFont.cpp - not sure if those are ones we need or not either.

The other non-RELEASE_OR_BETA code relates to reporting text performance metrics. IIRC this was always intended to be prerelease-only code, as gathering the metrics adds some (small) overhead, but it can be helpful when seeking to understand font- and text-related performance questions.

Assignee: nobody → jfkthame
Priority: -- → P3
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d89b9ad0613
Enable word-cache expiration timer up through early beta, to monitor stability in the wild. r=lsalzman
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.