about:preferences and extensionPermissions are at odds with each other
Categories
(WebExtensions :: Frontend, defect, P1)
Tracking
(firefox73 fixed)
Tracking | Status | |
---|---|---|
firefox73 | --- | fixed |
People
(Reporter: mixedpuppy, Assigned: mixedpuppy)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files, 1 obsolete file)
Specifically for newtab and homepage overrides, but possibly others:
about:preferences ui operates under an assumption that only one extension with these settings will ever be enabled. There is no multiple choice with extensions. If you want to change the setting, you must disable the controlling extension.
However, the way it actually works under the hood does not match this at all.
As long as you never touch about:preferences, you can install multiple extensions, have them all running, but only one will have control over the setting.
This needs to be addressed.
If we want to keep the concept of only one of these may be enabled, then we have to come up with rules around install/enable/upgrade. This will make for some strange UX.
-
install ext A with newtab
-
install ext B with newtab
- we must now disable ext A
-
install ext A with newtab
-
install ext B
-
ext B upgrades and adds newtab
- do we disable A or B?
Essentially, about:preferences is wrong. The extensions should be listed as options in the drop down menus for the homepage and newtab. That way users can select which to give control to.
Assignee | ||
Comment 1•5 years ago
|
||
The suggested fix is:
- do not disable the controls that allow selection
- add extensions into those controls so a user can choose different extensions without disabling something
- move the "disable" banners to match their setting (ie. homepage disable is under the newtab setting, weird)
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Updated•5 years ago
|
Comment 3•5 years ago
•
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #1)
Created attachment 9062382 [details]
Screen Shot 2019-05-02 at 4.22.01 PM.pngThe suggested fix is:
- do not disable the controls that allow selection
+1
- add extensions into those controls so a user can choose different extensions without disabling something
+1 (show "Extension : <extension name here> or something similar)
- move the "disable" banners to match their setting (ie. homepage disable is under the newtab setting, weird)
+1
And I'd also add one more:
- Remove the disable buttons entirely (no need for them anymore, user can select a different extension via dropdown)
Assignee | ||
Comment 4•5 years ago
|
||
Can you take a quick look at what we've decided?
Assignee | ||
Updated•5 years ago
|
Comment 5•5 years ago
|
||
(In reply to Shane Caraveo (:mixedpuppy) from comment #1)
Created attachment 9062382 [details]
Screen Shot 2019-05-02 at 4.22.01 PM.pngThe suggested fix is:
- do not disable the controls that allow selection
- add extensions into those controls so a user can choose different extensions without disabling something
- move the "disable" banners to match their setting (ie. homepage disable is under the newtab setting, weird)
Hey, I think this fix makes sense.
My recommandation for the string is:
$extension-name (extension)
Nice to have:
- show extension unique-icon in the list
[icon] $extension-name (extension)
eg. [tabbycat-icon] Tabby Cat (extension)
Updated•5 years ago
|
Assignee | ||
Comment 6•5 years ago
|
||
This adds support for selecting a specific extension to control a setting,
as well as allowing a user to take control without requiring the extension
to be disabled.
Assignee | ||
Updated•5 years ago
|
Updated•5 years ago
|
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6df3b83636f9 support selecting what controls an extension setting r=robwu
Comment 8•4 years ago
•
|
||
Backed out changeset 6df3b83636f9 (Bug 1548700) for causing failures in browser_searchDefaultEngine.js CLOSED TREE
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=279149050&repo=autoland&lineNumber=3336
Backout: https://hg.mozilla.org/integration/autoland/rev/37a8c7e8aa2e77ca99c24c98f794dcaf5bf5160d
Updated•4 years ago
|
Pushed by scaraveo@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/705eeb752bf0 support selecting what controls an extension setting r=robwu
Comment 10•4 years ago
|
||
bugherder |
Assignee | ||
Updated•4 years ago
|
Description
•