Spelling error in console warning: "Unkown category"

RESOLVED FIXED in Firefox 68

Status

()

defect
P3
normal
RESOLVED FIXED
2 months ago
Last month

People

(Reporter: jaws, Assigned: dilip.sridhar.c, Mentored)

Tracking

(Regression, {good-first-bug})

Trunk
mozilla68
Points:
---

Firefox Tracking Flags

(firefox-esr60 wontfix, firefox66 wontfix, firefox67 wontfix, firefox68 fixed)

Details

(Whiteboard: [good first bug][lang=c++])

Attachments

(1 attachment)

While fixing this bug, we should update the warning to include the category name that can't be found.

To help Mozilla out with this bug, here's the steps:

  1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
  2. Download and build the Firefox source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
  3. Start working on this bug.
    • Fix the typo mentioned in the first comment
    • Add the category name to the error message
    • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC (https://wiki.mozilla.org/Irc) most hours of most days.
  4. Build your change with mach build. Check your changes for adherence to our style guidelines by using mach lint
  5. Submit the patch for review. Mark me or :jaws as a reviewer so we'll get an email to come look at your code.
  6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
  7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.
Mentor: jrediger
Whiteboard: [good first bug][lang=c++]

:jaws, can you state what's the best way to include the category name? Just nsPrintfCString?

Flags: needinfo?(jaws)
Priority: -- → P3

The following compiles for me but I'm not sure if it's the best route:

NS_ConvertUTF8toUTF16(NS_LITERAL_CSTRING("Unknown category for SetEventRecordingEnabled: ") + category));

Georg, does that look OK to you?

Flags: needinfo?(jaws) → needinfo?(gfritzsche)
Flags: needinfo?(gfritzsche) → needinfo?(chutten)

Looks good to me.

Flags: needinfo?(chutten)
Comment hidden (typo)
Comment hidden (typo)
Comment hidden (typo)
Comment hidden (typo)
Comment hidden (typo)
Comment hidden (typo)
Assignee: nobody → dilip.sridhar.c
Status: NEW → ASSIGNED
Flags: needinfo?(jrediger)

Comment 13

Last month
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2400bc291ff5
Spelling error in console warning: "Unkown category". r=janerik

I approved the patch and pushed it off to autoland. After some tests it will get merged into the main repository and land in Firefox soon.

Assignee

Comment 15

Last month

Hey Jan,

Thanks for the review. Could you kindly help me find my next contribution.

Thanks,
//Dilip

Comment 16

Last month
bugherder
Status: ASSIGNED → RESOLVED
Closed: Last month
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

@DILIP: Unfortunately I don't have any good next bugs at hand in our Telemetry module, but if you head over to Codetribute you might be able to find something suitable in another part of Firefox or the wider Mozilla projects ecosystem.

Assignee

Comment 18

Last month

@Jan - I will check it out. Thank you for your support and mentoring with this bug. It was a great experience working with you.

Thanks,
//Dilip

You need to log in before you can comment on or make changes to this bug.