1548742 - Spelling error in console warning: "Unkown category"

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

See https://searchfox.org/mozilla-central/rev/b59a99943de4dd314bae4e44ab43ce7687ccbbec/toolkit/components/telemetry/core/TelemetryEvent.cpp#1347

Unkown should be replaced with Unknown.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

While fixing this bug, we should update the warning to include the category name that can't be found.

Comment 2

[Jan-Erik Rediger [:janerik]]

To help Mozilla out with this bug, here's the steps:

1. Comment here on the bug that you want to volunteer to help. I (or someone else) will assign it to you.
2. Download and build the Firefox source code: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Build_Instructions/Simple_Firefox_build
   • If you have any problems, please ask on IRC (https://wiki.mozilla.org/Irc) in the #introduction channel. They're there to help you get started.
   • You can also read the Developer Guide, which has answers to most development questions: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Introduction
3. Start working on this bug.
   • Fix the typo mentioned in the first comment
   • Add the category name to the error message
   • If you have any problems with this bug, please comment on this bug and set the needinfo flag for me. Also, you can find me and my teammates on the #telemetry channel on IRC (https://wiki.mozilla.org/Irc) most hours of most days.
4. Build your change with mach build. Check your changes for adherence to our style guidelines by using mach lint
5. Submit the patch for review. Mark me or :jaws as a reviewer so we'll get an email to come look at your code.
   • Here's the guide: https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
6. After a series of reviews and changes to your patch, I'll mark it for checkin or push it to autoland. Your code will soon be shipping to Firefox users worldwide!
7. ...now you get to think about what kind of bug you'd like to work on next. Let me know what you're interested in and I can help you find your next contribution.

Comment 3

[Jan-Erik Rediger [:janerik]]

:jaws, can you state what's the best way to include the category name? Just nsPrintfCString?

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

The following compiles for me but I'm not sure if it's the best route:

NS_ConvertUTF8toUTF16(NS_LITERAL_CSTRING("Unknown category for SetEventRecordingEnabled: ") + category));

Georg, does that look OK to you?

Comment 5

[Chris H-C :chutten]

Looks good to me.

Comment 6

[DILIP]

Hello,

I would like to take up this bug. Kindly assign it to me.

Thanks,
Dilip

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to DILIP from comment #6)

Hello,

I would like to take up this bug. Kindly assign it to me.

Thanks,
Dilip

Thanks for your interest. I usually assign bugs to people when they upload a patch. You may begin working on it now.

Comment 8

[DILIP]

Hello,

Should I run "mach lint" on the specific file or full wpt lint?

Thanks,
//Dilip

Comment 9

[DILIP]

Hello,

I have coded up the solution and mach build and mach lint were successful. I am finding difficulty in installing Arcanist and moz-phab on macOS to submit the patch. Could you please help me.

Thanks,
//Dilip

Comment 10

[DILIP]

Hello,

I followed the steps in this link "https://moz-conduit.readthedocs.io/en/latest/arcanist-macos.html". But arc and moz-phab commands are not working from my command line.

Thanks,
//Dilip

Comment 11

[DILIP]

Attachment: Bug 1548742 Spelling error in console warning: "Unkown category". r=janerik

Comment 12

[DILIP]

Hello,

I resolved the above issues with Arcanist and moz-phab. I have requested for code review using moz-phab. Could you kindly review my changes and let me know the next steps.

Thanks,
//Dilip

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2400bc291ff5
Spelling error in console warning: "Unkown category". r=janerik

Comment 14

[Jan-Erik Rediger [:janerik]]

I approved the patch and pushed it off to autoland. After some tests it will get merged into the main repository and land in Firefox soon.

Comment 15

[DILIP]

Hey Jan,

Thanks for the review. Could you kindly help me find my next contribution.

Thanks,
//Dilip

Comment 16

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/2400bc291ff5

Comment 17

[Jan-Erik Rediger [:janerik]]

@DILIP: Unfortunately I don't have any good next bugs at hand in our Telemetry module, but if you head over to Codetribute you might be able to find something suitable in another part of Firefox or the wider Mozilla projects ecosystem.

Comment 18

[DILIP]

@Jan - I will check it out. Thank you for your support and mentoring with this bug. It was a great experience working with you.

Thanks,
//Dilip