Tee URL escaping fails in some degenerate cases
Categories
(Data Platform and Tools :: General, defect)
Tracking
(Not tracked)
People
(Reporter: whd, Unassigned)
Details
In some rare cases such as "/submit/? !" the hindsight http output fails with an assert. Initial investigation by :trink suggests that escaping isn't happening properly for certain garbage submissions, causing the server to respond with a 400 (bad request), in turn causing an unexpected assert in lua due to premature socket closure. We should investigate why the url escaping fails in these edge cases and fix it so that we can pass similar garbage on to the gcp pipeline.
|
Reporter | |
Comment 1•6 years ago
|
||
I sent a request a garbage submission to stage for testing that returned a 200:
curl -v -d '{}' 'https://stage.ingestion.nonprod.dataops.mozgcp.net/submit/?%20!'
and trying to send data without escaping the space causes a 400 at the load balancer level in both AWS and GCP. We therefore are confident that the GCP edge will handle these kinds of garbage submission correctly once the tee is removed, so there's nothing else to do here.
|
Assignee | |
Updated•3 years ago
|
Description
•