1548769 - Remove code to change icons

Status: RESOLVED FIXED

(WebExtensions :: Themes, task, P2)

Description

[Tim Nguyen :ntim]

Right now, themes support changing icon images behind the "extensions.webextensions.themes.icons.enabled" preference which is disabled by default. Since we have no idea when this is going to be enabled, let's remove the code and re-introduce later if needed.

Comment 1

[Tim Nguyen :ntim]

Attachment: Bug 1548769 - Remove WebExtensions icons theming support. r=mikedeboer

Comment 2

[Mike de Boer [:mikedeboer]]

Well, this might be a cause of upset for ThunderBird devs, because they enabled support by default.

Comment 3

[Tim Nguyen :ntim]

(In reply to Mike de Boer [:mikedeboer] from comment #2)

Well, this might be a cause of upset for ThunderBird devs, because they enabled support by default.

It's disabled by default in TB as well (just tested now in the latest Daily build), TB just inherits the toolkit pref value.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e8dbcc5c516f
Remove WebExtensions icons theming support. r=mikedeboer

Comment 5

[Andreea Pavel [:apavel]]

Backed out for failing test_ext_manifest_themes.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=e8dbcc5c516f05fe34f90efaf6fd199118979012&selectedJob=245404934

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245404934&repo=autoland&lineNumber=2313

Backout: https://hg.mozilla.org/integration/autoland/rev/eb55d30a839a

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a0ab4288cda4
Remove WebExtensions icons theming support. r=mikedeboer

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/a0ab4288cda4

Comment 8

[Madalin Cotetiu]

Can you please provide some STR for this issue so we can check it manually? If no manual testing is needed please mark it as "qe-verify- "