Closed Bug 1548769 Opened 6 months ago Closed 5 months ago

Remove code to change icons

Categories

(WebExtensions :: Themes, task, P2)

task

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: ntim, Assigned: ntim)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Right now, themes support changing icon images behind the "extensions.webextensions.themes.icons.enabled" preference which is disabled by default. Since we have no idea when this is going to be enabled, let's remove the code and re-introduce later if needed.

Well, this might be a cause of upset for ThunderBird devs, because they enabled support by default.

(In reply to Mike de Boer [:mikedeboer] from comment #2)

Well, this might be a cause of upset for ThunderBird devs, because they enabled support by default.

It's disabled by default in TB as well (just tested now in the latest Daily build), TB just inherits the toolkit pref value.

Flags: needinfo?(mdeboer)
Priority: -- → P2
Depends on: 1550090
Blocks: 1550090
No longer depends on: 1550090
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/e8dbcc5c516f
Remove WebExtensions icons theming support. r=mikedeboer
Flags: needinfo?(mdeboer)
Blocks: 1550151
Flags: needinfo?(ntim.bugs)
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a0ab4288cda4
Remove WebExtensions icons theming support. r=mikedeboer
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → ntim.bugs

Can you please provide some STR for this issue so we can check it manually? If no manual testing is needed please mark it as "qe-verify- "

Flags: needinfo?(ntim.bugs)
Flags: qe-verify-
Flags: needinfo?(ntim.bugs)
Type: defect → task
You need to log in before you can comment on or make changes to this bug.