Closed Bug 1548784 Opened 6 months ago Closed 4 months ago

Bookmark Panel message requires variable height

Categories

(Firefox :: Messaging System, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
69.4 - Jun 24 - Jul 7
Tracking Status
firefox69 + fixed
firefox70 --- fixed

People

(Reporter: andreio, Assigned: andreio)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Right now the panel has fixed height that will only work with a similar length message. We need to make this adjustable.

Priority: -- → P2
Blocks: cfr
No longer blocks: 1541914
Component: Activity Streams: Newtab → Messaging System
See Also: → 1562166
Pushed by aoprea@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bd1d6fea6587
Bookmark Panel message requires variable height r=k88hudson

[Tracking Requested - why for this release]: this fixes bug #1562166, which gave bad bookmark panel message for RU

Priority: P2 → P1
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Target Milestone: Firefox 69 → Firefox 70
Iteration: --- → 69.4 - Jun 24 - Jul 7

Please nominate this for Beta approval when you get a chance.

Flags: needinfo?(andrei.br92)

Comment on attachment 9075921 [details]
Bug 1548784 - Bookmark Panel message requires variable height

Beta/Release Uplift Approval Request

  • User impact if declined: For some locales the user experience will be affected
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Changes have been tests and are covered by tests
  • String changes made/needed:
Flags: needinfo?(andrei.br92)
Attachment #9075921 - Flags: approval-mozilla-beta?

Comment on attachment 9075921 [details]
Bug 1548784 - Bookmark Panel message requires variable height

Bookmark panel improvements for some locales. Approved for 69.0b5.

Attachment #9075921 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.