1548802 - Merge devtools/client/shared/components/menu/utils.js in devtools/client/framework/menu.js

Status: NEW

(DevTools :: Framework, enhancement, P3)

Description

[Julian Descottes [:jdescottes]]

Follow up to Bug 1543940.

After Bug 1543940, menu/utils.js will only provide one feature missing from the base menu.js file: opening menus on a target Element rather than at x, y coordinates.

    const button = options.button;
    const rect = button.getBoundingClientRect();
    const defaultView = button.ownerDocument.defaultView;
    screenX = rect.left + defaultView.mozInnerScreenX;
    screenY = rect.bottom + defaultView.mozInnerScreenY;

If we add this feature to menu.js, it feels like we should be able to have only one menu file.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Bugbug thinks this bug should belong to this component, but please revert this change in case of error.