1548848 - Doesn't update assigned node for slots correctly in certain case

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Edgar Chen [:edgar]]

I found this issue while reviewing https://github.com/whatwg/dom/pull/695.

Here is the test script: https://software.hixie.ch/utilities/js/live-dom-viewer/?saved=6885

Expected result:
We should assign p with slot="assigned1" to slot with id="slot3"
after p in shadowRoot1 is removed.

Actual result:
We fall back to slotable child of slot3.

Comment 1

[Edgar Chen [:edgar]]

And I got this assertion in debug build.

Assertion failure: content->GetFlattenedTreeParentNodeForStyle() (Node not in the flattened tree still has a frame?), at /Users/edgarchen/Workspace/mercurial/mozilla-central/layout/base/PresShell.cpp:3985
#01: AssertFrameSubtreeIsSane(nsIFrame const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x663ecc1]
#02: AssertFrameSubtreeIsSane(nsIFrame const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x663ed93]
#03: AssertFrameSubtreeIsSane(nsIFrame const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x663ed93]
#04: AssertFrameSubtreeIsSane(nsIFrame const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x663ed93]
#05: AssertFrameSubtreeIsSane(nsIFrame const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x663ed93]
#06: AssertFrameSubtreeIsSane(nsIFrame const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x663ed93]
#07: AssertFrameSubtreeIsSane(nsIFrame const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x663ed93]
#08: AssertFrameSubtreeIsSane(nsIFrame const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x663ed93]
#09: AssertFrameSubtreeIsSane(nsIFrame const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x663ed93]
#10: AssertFrameTreeIsSane(mozilla::PresShell const&)[/Users/edgarchen/Workspace/mercurial/mozilla-central/objdir-debug/dist/NightlyDebug.app/Contents/MacOS/XUL +0x660362d]
...

Comment 2

[Edgar Chen [:edgar]]

Attachment: reduced testcase

It looks like we probably need something similar like bug 1435632.

Comment 3

[Edgar Chen [:edgar]]

Attachment: Bug 1548848 - Moving assigned nodes caused by slot removal should properly invalidate layout;

Comment 4

[Edgar Chen [:edgar]]

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1&revision=a3550e50c2d8eb0ea2940f0444885a8eba74445e&group_state=expanded

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6bc3bde65d6
Moving assigned nodes caused by slot removal should properly invalidate layout; r=emilio

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/d6bc3bde65d6

Comment 7

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16878 for changes under testing/web-platform/tests

Comment 8

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Upstream PR merged