1548849 - Crash in [@ webrender::prim_store::PrimitiveStore::request_resources_for_prim]

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[Calixte Denizet (:calixte)]

This bug is for crash report bp-79a15ead-341a-4084-9bb3-1d2050190503.

Top 10 frames of crashing thread:

0 libxul.so GeckoCrash toolkit/xre/nsAppRunner.cpp:5076
1 libxul.so gkrust_shared::panic_hook toolkit/library/rust/shared/lib.rs:241
2 libxul.so core::ops::function::Fn::call src/libcore/ops/function.rs:69
3 libxul.so rust_panic_with_hook src/libstd/panicking.rs:482
4 libxul.so std::panicking::begin_panic src/libstd/panicking.rs:412
5 libxul.so webrender::prim_store::PrimitiveStore::request_resources_for_prim gfx/wr/webrender/src/glyph_rasterizer/no_pathfinder.rs:49
6 libxul.so webrender::prim_store::PrimitiveStore::update_visibility gfx/wr/webrender/src/prim_store/mod.rs:2015
7 libxul.so webrender::prim_store::PrimitiveStore::update_visibility gfx/wr/webrender/src/prim_store/mod.rs:1814
8 libxul.so webrender::prim_store::PrimitiveStore::update_visibility gfx/wr/webrender/src/prim_store/mod.rs:1814
9 libxul.so webrender::frame_builder::FrameBuilder::build_layer_screen_rects_and_cull_layers gfx/wr/webrender/src/frame_builder.rs:402

There is 1 crash in nightly 68 with buildid 20190502220333. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1548202.

[1] https://hg.mozilla.org/mozilla-central/rev?node=9ec9c4c0be3b

Comment 1

[Glenn Watson [:gw]]

The panic is coming from the assert in https://hg.mozilla.org/mozilla-central/annotate/bdf36faf780ba706bbebc8cbcd32ba892a899440/gfx/wr/webrender/src/glyph_rasterizer/no_pathfinder.rs#l49.

I confirmed with lsalzman that we've seen this crash before. I suspect it's just appearing as a new crash because the call site of request_glyphs was changed by the referenced patch above, which will change the signature of the crash due to function inlining.

This is one of those crashes that will probably be very easy to fix if we have a URL that reproduces the problem, but near impossible to see what is happening without a repro.

Comment 2

[Patricia Lawless]

Hi Jessie, will this be worked on for 68? Thanks!

Comment 3

[Jessie [:jbonisteel] pls NI]

Unlikely to be worked on for 68, unless we can find consistent way to repro.

Comment 4

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jbonisteel, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Closing because no crashes reported for 12 weeks.