Closed
Bug 1548922
Opened 5 years ago
Closed 5 years ago
[eslint] TypeError: Cannot read property 'name' of undefined
Categories
(Developer Infrastructure :: Lint and Formatting, defect, P2)
Developer Infrastructure
Lint and Formatting
Tracking
(firefox68 fixed)
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: glasserc, Assigned: standard8)
Details
Attachments
(1 file)
Trying to lint a file (in particular https://phabricator.services.mozilla.com/D29873#change-QXf8nf63T8qQ) produces this:
An error occurred running eslint. Please check the following error messages:
TypeError: Cannot read property 'name' of undefined
Occurred while linting /home/ethan/Jobs/Mozilla/gecko-git/toolkit/components/normandy/actions/SinglePreferenceExperimentAction.jsm:22
at VariableDeclarator (/home/ethan/Jobs/Mozilla/gecko-git/tools/lint/eslint/eslint-plugin-mozilla/lib/rules/no-define-cc-etc.js:31:59)
at listeners.(anonymous function).forEach.listener (/home/ethan/Jobs/Mozilla/gecko-git/node_modules/eslint/lib/util/safe-emitter.js:45:58)
at Array.forEach (<anonymous>)
at Object.emit (/home/ethan/Jobs/Mozilla/gecko-git/node_modules/eslint/lib/util/safe-emitter.js:45:38)
at NodeEventGenerator.applySelector (/home/ethan/Jobs/Mozilla/gecko-git/node_modules/eslint/lib/util/node-event-generator.js:251:26)
at NodeEventGenerator.applySelectors (/home/ethan/Jobs/Mozilla/gecko-git/node_modules/eslint/lib/util/node-event-generator.js:280:22)
at NodeEventGenerator.enterNode (/home/ethan/Jobs/Mozilla/gecko-git/node_modules/eslint/lib/util/node-event-generator.js:294:14)
at CodePathAnalyzer.enterNode (/home/ethan/Jobs/Mozilla/gecko-git/node_modules/eslint/lib/code-path-analysis/code-path-analyzer.js:632:23)
at nodeQueue.forEach.traversalInfo (/home/ethan/Jobs/Mozilla/gecko-git/node_modules/eslint/lib/linter.js:752:32)
at Array.forEach (<anonymous>)
A failure occurred in the eslint linter.
✖ 1 problem (0 errors, 0 warnings, 1 failure)
I think this is due to use of the "rest" spread.
Updated•5 years ago
|
Summary: TypeError: Cannot read property 'name' of undefined → [eslint] TypeError: Cannot read property 'name' of undefined
Assignee | ||
Comment 1•5 years ago
|
||
Thanks for filing, you're quite right, we're not handling the different type of the spread properly.
Assignee: nobody → standard8
Status: NEW → ASSIGNED
Priority: -- → P2
Assignee | ||
Comment 2•5 years ago
|
||
Pushed by mbanner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/eea0648e7d30 Fix handling of spread operators when checking the ESLint rule no-define-cc-etc. r=dthayer
Comment 4•5 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Updated•2 years ago
|
Product: Firefox Build System → Developer Infrastructure
You need to log in
before you can comment on or make changes to this bug.
Description
•