Closed Bug 1548939 Opened 9 months ago Closed 9 months ago

Devirtualize IPDL calls to BrowserChild and organize methods a bit

Categories

(Core :: DOM: Content Processes, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: rhunt, Assigned: rhunt)

Details

Attachments

(13 files)

47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review
47 bytes, text/x-phabricator-request
Details | Review

I wrote some patches for bug 1519546 that I'd like to land sooner than later.

This isn't needed now that BrowserParent has the same name
as the protocol.

Somehow all of the member variables of BrowserParent have been
spread around the class. This makes it really hard to understand
what state there is. This commit moves all member variables
(preserving order) to the bottom of the class.

Depends on D29899

This is the followup to the previous patch, and attempts to organize
state to be a bit more logical.

Depends on D29900

The methods in BrowserParent are a bit disorganized. There's a lot to
do to fix that, but an easy first step is to move static methods to
the top of the class.

Depends on D29901

The next easy step is to move the getters below the static methods.

Depends on D29902

Summary: Devirtualize IPDL calls to BrowserParent and organize methods a bit → Devirtualize IPDL calls to BrowserChild and organize methods a bit

This isn't needed now that BrowserParent has the same name
as the protocol.

Depends on D30150

Somehow all of the member variables of BrowserParent have been
spread around the class. This makes it really hard to understand
what state there is. This commit moves all member variables
(preserving order) to the bottom of the class.

Depends on D30152

This is the followup to the previous patch, and attempts to organize
state to be a bit more logical.

Depends on D30153

The methods in BrowserParent are a bit disorganized. There's a lot to
do to fix that, but an easy first step is to move static methods to
the top of the class.

Depends on D30154

The next easy step is to move the getters below the static methods.

Depends on D30155

Pushed by rhunt@eqrion.net:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bc84c39a78f2
Devirtualize BrowserChild IPDL methods. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/ddb24aab9b6e
Remove direct_call overrides for PBrowser. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/aafed4d2be50
Update include guard on the header for BrowserParent. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/411729b65f07
Move all BrowserParent state into one contiguous block. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/cd87583bb3ab
Rearrange state on BrowserParent to logical groups. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/09a84bebb63f
Move static methods to top of BrowserParent. r=nika
https://hg.mozilla.org/integration/mozilla-inbound/rev/0214c4b7b50c
Move method getters to the top of BrowserParent. r=nika
You need to log in before you can comment on or make changes to this bug.