Closed Bug 1548959 Opened 4 months ago Closed 4 months ago

Media_codec_used should be available in release

Categories

(Core :: Audio/Video: Playback, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox67 --- fixed
firefox68 --- fixed

People

(Reporter: drno, Assigned: drno)

Details

Attachments

(2 files)

The Telemetry probe MEDIA_CODEC_USED should not only collect in Nightly and Beta, but also in Release.

Short note: New or changed data collections are subject to Data Collection Review (including changes like expanding the audience the way this change does). You may have already planned to seek review, if so: sorry for the interruption!

Attachment #9063118 - Flags: data-review?(chutten)
Attachment #9063118 - Flags: data-review?(chutten) → data-review?(tdsmith)
Comment on attachment 9063118 [details]
data_collection_request.md

data-review+; thanks!

--

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes, in Histograms.json.

Examples of the histogram keys are given in https://bugzilla.mozilla.org/show_bug.cgi?id=1226450#c11.

2) Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Yes, the [Firefox telemetry opt-out](https://support.mozilla.org/en-US/kb/share-data-mozilla-help-improve-firefox).

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Nils Ohlmeier and Jean-Yves Avenard.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, technical data.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers**?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No)

No, permanent collection.

9) Does the data collection use a third-party collection tool?

No.
Attachment #9063118 - Flags: data-review?(tdsmith) → data-review+
Pushed by nohlmeier@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/61543755b781
enable media_codec_used in release r=bryce
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Comment on attachment 9062634 [details]
Bug 1548959: enable media_codec_used in release

Beta/Release Uplift Approval Request

  • User impact if declined: Firefox management will not know how much the new AV1 decoder dav1d in Fx 67 is used by Firefox release population and might not make the right decision on where to invest engineering resources.
  • Is this code covered by automated tests?: Unknown
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Because it only allows an existing Telemetry probe to get collected in Release as well.
  • String changes made/needed: N/A
Attachment #9062634 - Flags: approval-mozilla-beta?

Comment on attachment 9062634 [details]
Bug 1548959: enable media_codec_used in release

low risk, has data-review+, approved for our beta branch, thanks.

Attachment #9062634 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.