Closed Bug 1549033 Opened 6 months ago Closed 3 months ago

Don't dump PERFHERDER_DATA from test type "scenario" when a resource usage flag (power, memory, cpu) is not supplied

Categories

(Testing :: Raptor, defect, P1, major)

Version 3
defect

Tracking

(firefox69 fixed)

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: stephend, Assigned: sparky)

Details

Attachments

(1 file)

From Rob, wisely, over in https://phabricator.services.mozilla.com/D29654#876944 from bug 1546741[0].

Bug: if the user doesn't specify --power-test, --cpu-test, or --memory-test, don't dump any actual PERFHERDER_DATA

DO

  • dump PERFHERDER_DATA from this run:
./mach raptor-test --test raptor-scn-power-idle-geckoview --app=geckoview --binary="org.mozilla.geckoview_example"

DO NOT

  • dump PERFHERDER_DATA from this run:
./mach raptor-test --power-test --host 168.2.1.0 --test raptor-scn-power-idle-geckoview --app=geckoview --binary="org.mozilla.geckoview_example"

[0] "For scenario type tests, don't dump any actual PERFHERDER_DATA for the scenario test alone. If actual data is required then the user (or taskcluster config) will need to add --power-test, or --memory-test, or soon Chris' --cpu-test.

For the Raptor 'scenario' test type, this patch prevents PERFHERDER_DATA from being output when --power-test, --cpu-test, or --memory-test are not used.

The priority flag is not set for this bug.
:rwood, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(rwood)
Assignee: nobody → gmierz2
Status: NEW → ASSIGNED
Priority: -- → P1
Flags: needinfo?(rwood)
Priority: P1 → P2
Summary: Don't dump actual PERFHERDER_DATA from new test type "scenario" (power, memory, CPU usage) without using one of those subtypes/flags → Don't dump PERFHERDER_DATA from test type "scenario" when a resource usage flag (power, memory, cpu) is not supplied
Priority: P2 → P1
Pushed by gmierz2@outlook.com:
https://hg.mozilla.org/integration/autoland/rev/ac31aae4bcd4
Only dump PERFHERDER_DATA when scenario tests are run with a resource usage flag. r=perftest-reviewers,stephendonner,rwood
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.