1549049 - cannot view last sync time

Status: RESOLVED FIXED

(Firefox :: Sync, defect, P2)

Description

[Lazy Monkey]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/74.0.3729.131 Safari/537.36

Steps to reproduce:

on nightly build, after recent changes, I cannot see anymore the tooltip with the time of last sync. please readd the tooltip or a label with last successful sync time.
thanks.

Comment 1

[Ryan Kelly [:rfkelly]]

Thanks for the report for completeness, could you please be more specific about where you are expecting to see the tooltip, perhaps by sharing a screenshot?

IIRC one place this it used to appear was when hovering over the row for your Firefox Account in the hamburger menu. Vijay, was this changes as part of the recent work on the FxA toolbar icon?

Comment 2

[Mark Hammond [:markh] [:mhammond]]

I'm fairly sure this is a regression from bug 1542334.

https://searchfox.org/mozilla-central/rev/b2015fdd464f598d645342614593d4ebda922d95/browser/base/content/browser-sync.js#974 should also be setting the attribute on 'PanelUI-fxa-menu-syncnow-button' (although it could also be argued it might as well be also be on 'appMenu-fxa-label' (ie, the item that remains on the top-level menu and opens the sub-menu).

Comment 3

[Vijay Budhram]

It was a design decision to remove the tooltip from the top level app menu because the user could not manually initiate sync there. However, I think it is reasonable to show it somewhere, possible the submenu button Sync Now? rfelley thoughts?

Comment 4

[Ryan Feeley [:rfeeley]]

Definitely put it on the Sync Now in the menu.

Today the toolbar icon says "Firefox Account" no matter the state of the account.

This makes sense when the user is not signed in.

Perhaps when they sign in we can repeat the last sync time there too.

Objections?

Comment 5

[Ryan Kelly [:rfkelly]]

Today the toolbar icon says "Firefox Account" no matter the state of the account.
Perhaps when they sign in we can repeat the last sync time there too.

Alternately, some sort of "Signed in as X" tooltip might be appropriate in this case.

Comment 6

[Ryan Feeley [:rfeeley]]

Agreed! Exactly that: Signed in as [e-mail].

We avoid using display name, even if it's available, because it can be anything, even [e-mail]

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:markh, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 8

[Mark Hammond [:markh] [:mhammond]]

Vijay, I'm per-emptively assigning this to you, I hope that's OK.

Comment 10

[Edouard Oger [:eoger]]

Attachment: Bug 1549049 - Unify Sync Now buttons logic.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4695136f7e82
Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod

Comment 12

[Andreea Pavel [:apavel]]

Backed out for assertion failures at ErrorResult.h

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=pending%2Crunning%2Ctestfailed%2Cbusted%2Cexception&revision=4695136f7e822e205c86e6a2e0e570f749baaeb7&selectedJob=270784238

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=270784238&repo=autoland&lineNumber=1612

Backout: https://hg.mozilla.org/integration/autoland/rev/595a7ff758ed1390f7d7fbfc3f116032b6aa6788

Comment 13

[Andreea Pavel [:apavel]]

This also caused other test failures (several browser chrome and devtools): https://treeherder.mozilla.org/#/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=ff3193607ca632809f7a97dc2a429fff3d167aac&searchStr=linux%2Cx64%2Casan&failure_classification_id=2&selectedJob=270788461

Comment 14

[Edouard Oger [:eoger]]

I can't NI? Zibi till they're back from PTO, but they need to have a look before we can re-land this since we add sync.ftl to browser.xhtml.

Comment 15

[Edouard Oger [:eoger]]

Actually data-lazy-l10n-id should do the trick.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/12ff69a8f360
Unify Sync Now buttons logic. r=markh,fluent-reviewers,flod

Comment 17

[:Gijs (he/him)]

Can you file a follow-up about the assertion failure? It looks dodgy - we're ignoring a failure somewhere, we should either be explicit about it or handle it properly (but also, what's failing and why?).

Comment 18

[Edouard Oger [:eoger]]

Filed bug 1588163.

Comment 19

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/12ff69a8f360