1549054 - OSX Mojave (10.14) - browser_toggleSimple.js, browser_toggleTransparentOverlay-*.js fail

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect, P3)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

in working to get tests running on osx 10.14 (vs 10.10 currently) some tests fail. These new tests added last week in bug 1540835 seem to fail on osx 10.14.

here is a try push showing a failure:
https://treeherder.mozilla.org/#/jobs?repo=try&searchStr=osx%2Cbrowser%2Cdebug%2Cbc1&revision=27d8e706de22ac93732dab0733347657e2a6433f

and a screenshot of the failure:
https://taskcluster-artifacts.net/GXd2sYsmSsSZu3gpAwQl5g/0/public/test_info/mozilla-test-fail-screenshot_CdMcbz.png

^ cool picture btw :)

in the log:
https://taskcluster-artifacts.net/GXd2sYsmSsSZu3gpAwQl5g/0/public/logs/live_backing.log

I see:
01:07:39 INFO - TEST-START | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js
01:07:41 INFO - GECKO(1967) | JavaScript error: resource://gre/actors/PictureInPictureChild.jsm, line 560: NS_ERROR_NOT_INITIALIZED
01:09:09 INFO - TEST-INFO | started process screencapture
01:09:09 INFO - TEST-INFO | screencapture: exit 0
01:09:09 INFO - Buffered messages logged at 01:07:39
01:09:09 INFO - Entering test bound
01:09:09 INFO - Waiting for videos to be ready
01:09:09 INFO - Testing video with id: with-controls
01:09:09 INFO - Waiting for toggle to become visible
01:09:09 INFO - Buffered messages logged at 01:07:40
01:09:09 INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js | Toggle reached target opacity. - true == true -
01:09:09 INFO - Hovering the toggle rect now.
01:09:09 INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js | Toggle reached target opacity. - true == true -
01:09:09 INFO - Clicking on toggle, and expecting a Picture-in-Picture window to open
01:09:09 INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js | A Picture-in-Picture window opened. -
01:09:09 INFO - Testing video with id: no-controls
01:09:09 INFO - Waiting for toggle to become visible
01:09:09 INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js | Toggle reached target opacity. - true == true -
01:09:09 INFO - Hovering the toggle rect now.
01:09:09 INFO - Buffered messages logged at 01:07:41
01:09:09 INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js | Toggle reached target opacity. - true == true -
01:09:09 INFO - Clicking on toggle, and expecting a Picture-in-Picture window to open
01:09:09 INFO - Console message: [JavaScript Error: "NS_ERROR_NOT_INITIALIZED" {file: "resource://gre/actors/PictureInPictureChild.jsm" line: 560}]
01:09:09 INFO - Buffered messages finished
01:09:09 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js | Test timed out -
01:09:09 INFO - GECKO(1967) | MEMORY STAT | vsize 7576MB | residentFast 338MB | heapAllocated 82MB
01:09:09 INFO - TEST-OK | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js | took 90143ms
01:09:09 INFO - Not taking screenshot here: see the one that was previously logged
01:09:09 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js | Found a tab after previous test timed out: http://example.com/browser/toolkit/components/pictureinpicture/tests/test-page.html -
01:09:09 INFO - GECKO(1967) | ++DOCSHELL 0x10aa44000 == 1 [pid = 1969] [id = {72511fc9-3eba-f74c-b8c1-27aff5011bcc}]
01:09:09 INFO - GECKO(1967) | ++DOMWINDOW == 1 (0x118f3c020) [pid = 1969] [serial = 11] [outer = 0x0]
01:09:09 INFO - GECKO(1967) | ++DOMWINDOW == 2 (0x10b414c00) [pid = 1969] [serial = 12] [outer = 0x118f3c020]
01:09:09 INFO - checking window state
01:09:09 INFO - GECKO(1967) | ++DOMWINDOW == 3 (0x1133db000) [pid = 1969] [serial = 13] [outer = 0x118f3c020]
01:09:09 INFO - TEST-START | toolkit/components/pictureinpicture/tests/browser_toggleTransparentOverlay-1.js
01:09:09 INFO - GECKO(1967) | ++DOCSHELL 0x11f59b800 == 2 [pid = 1972] [id = {3bbb7791-56a6-9e43-8fab-e7ef43771abb}]
01:09:09 INFO - GECKO(1967) | ++DOMWINDOW == 3 (0x126c4b200) [pid = 1972] [serial = 30] [outer = 0x0]
01:09:09 INFO - GECKO(1967) | ++DOMWINDOW == 4 (0x12108b000) [pid = 1972] [serial = 31] [outer = 0x126c4b200]
01:09:09 INFO - GECKO(1967) | ++DOMWINDOW == 5 (0x126f89000) [pid = 1972] [serial = 32] [outer = 0x126c4b200]
01:09:10 INFO - GECKO(1967) | ++DOCSHELL 0x1123aa800 == 6 [pid = 1967] [id = {8b14ae0a-6c80-3e4e-b3c3-1b0fe9eaed45}]
01:09:10 INFO - GECKO(1967) | ++DOMWINDOW == 11 (0x10af1e880) [pid = 1967] [serial = 30] [outer = 0x0]
01:09:10 INFO - GECKO(1967) | ++DOMWINDOW == 12 (0x11dcb8000) [pid = 1967] [serial = 31] [outer = 0x10af1e880]
01:09:10 INFO - Not taking screenshot here: see the one that was previously logged
01:09:10 INFO - Buffered messages logged at 01:09:09
01:09:10 INFO - Entering test bound
01:09:10 INFO - Waiting for videos to be ready
01:09:10 INFO - Testing video with id: video-transparent-background
01:09:10 INFO - Buffered messages logged at 01:09:10
01:09:10 INFO - Waiting for toggle to become visible
01:09:10 INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggleTransparentOverlay-1.js | Toggle reached target opacity. - true == true -
01:09:10 INFO - Hovering the toggle rect now.
01:09:10 INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggleTransparentOverlay-1.js | Toggle reached target opacity. - true == true -
01:09:10 INFO - Clicking on toggle, and expecting a Picture-in-Picture window to open
01:09:10 INFO - TEST-PASS | toolkit/components/pictureinpicture/tests/browser_toggleTransparentOverlay-1.js | A Picture-in-Picture window opened. -
01:09:10 INFO - Buffered messages finished
01:09:10 INFO - TEST-UNEXPECTED-FAIL | toolkit/components/pictureinpicture/tests/browser_toggleSimple.js | Uncaught exception received from previously timed out test - at chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/head.js:185 - ReferenceError: ok is not defined
01:09:10 INFO - Stack trace:
01:09:10 INFO - testToggle/<@chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/head.js:185:9
01:09:10 INFO - asyncwithNewTab@resource://testing-common/BrowserTestUtils.jsm:111:24
01:09:10 INFO - asynctestToggle@chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/head.js:108:26
01:09:10 INFO - @chrome://mochitests/content/browser/toolkit/components/pictureinpicture/tests/browser_toggleSimple.js:14:9
01:09:10 INFO - Tester_execTest/<@chrome://mochikit/content/browser-test.js:1116:34
01:09:10 INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1144:12
01:09:10 INFO - nextTest/<@chrome://mochikit/content/browser-test.js:1005:14
01:09:10 INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:803:59
01:09:10 INFO - Testing video with id: video-alpha-background
01:09:10 INFO - Waiting for toggle to become visible

I am not sure what is going on, :mconley could you help out?

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Hey jmaher, with bug 1546887 fixed, is this still failing?

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

this passes just fine now. Thanks for fixing it.