1549101 - Port bug 1545242: UI to Select DNS over HTTPS Provider

Status: RESOLVED FIXED

(Thunderbird :: Preferences, task)

Description

[Richard Marti (:Paenglab)]

Bug 1545242 changed the DoH provider selection to a menulist to add more providers.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1549101-connection-DoH.patch

Because it was too complicated to convert the Fluent logic I decided to copy the m-c connection.js file and remove the Add-on proxy customization part. Because of the port I'm using now for the new strings Fluent.

They also reintroduced a grid which I haven't followed. It's now not aligned like in FX but the actual UI looks similar.

Because the hiding/showing of the custom row makes the dialog jump, I use the visibility instead of the hidden attribute.

In the commit message I also added the bugs that are now also included with the port.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9062733 [details] [diff] [review]
1549101-connection-DoH.patch

Review of attachment 9062733 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, r=mkmelin

Comment 3

[Jorg K (CEST = GMT+2)]

Please run the linter before submitting a patch or when reviewing it. I'll fix the four (trivial) linting errors, no new patch required.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/066776998cb4
Port bug 1499795, bug 1533263 and bug 1545242: DNS over HTTPS Provider. r=mkmelin