Closed
Bug 154914
Opened 22 years ago
Closed 22 years ago
Press Enter on collapsed history tree item causes page load.
Categories
(Core Graveyard :: History: Global, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: smeredith, Assigned: yuanyi21)
Details
Attachments
(1 file, 1 obsolete file)
|
612 bytes,
patch
|
yuanyi21
:
review+
bugzilla
:
superreview+
|
Details | Diff | Splinter Review |
Open the history window. Highlight a collapsed tree item, like "Today" for example. Press Enter. The focus changes to a browser window and a page tries to load. I'm not sure what the URL is.
Yes, that leads me to http://apps5.oingo.com/apps/domainpark/domainpark.cgi?s=find&dp_lp=7&cid=GOTO6262&dp_format=1.3&dp_p4pid=idealab&dp_own=Idealab&dp_cm=_b&dp_c1=000099 seems like a search page.
Comment on attachment 89870 [details] [diff] [review] don't open url if the selected item is a container i'd prefer this: - else + else { + if (! isContainer(gHistoryTree, currentIndex))
Attachment #89870 -
Flags: review+
Attachment #89870 -
Attachment is obsolete: true
Comment on attachment 89909 [details] [diff] [review] revised per timeless's suggestions carrying r=timeless
Attachment #89909 -
Flags: review+
|
||
Comment 7•22 years ago
|
||
Comment on attachment 89909 [details] [diff] [review] revised per timeless's suggestions sr=blake
Attachment #89909 -
Flags: superreview+
checked in.
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•