Press Enter on collapsed history tree item causes page load.

RESOLVED FIXED

Status

RESOLVED FIXED
17 years ago
3 months ago

People

(Reporter: smeredith, Assigned: yuanyi21)

Tracking

Trunk
x86
Windows XP

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

17 years ago
Open the history window. Highlight a collapsed tree item, like "Today" for
example. Press Enter. The focus changes to a browser window and a page tries to
load. I'm not sure what the URL is.
(Assignee)

Comment 2

17 years ago
taking...
Assignee: blaker → kyle.yuan
(Assignee)

Comment 3

17 years ago
Created attachment 89870 [details] [diff] [review]
don't open url if the selected item is a container


seeking r=

Comment 4

17 years ago
Comment on attachment 89870 [details] [diff] [review]
don't open url if the selected item is a container

i'd prefer this:
-    else
+    else {
+      if (! isContainer(gHistoryTree, currentIndex))
Attachment #89870 - Flags: review+
(Assignee)

Comment 5

17 years ago
Created attachment 89909 [details] [diff] [review]
revised per timeless's suggestions
Attachment #89870 - Attachment is obsolete: true
(Assignee)

Comment 6

17 years ago
Comment on attachment 89909 [details] [diff] [review]
revised per timeless's suggestions

carrying r=timeless
Attachment #89909 - Flags: review+

Comment 7

17 years ago
Comment on attachment 89909 [details] [diff] [review]
revised per timeless's suggestions

sr=blake
Attachment #89909 - Flags: superreview+
(Assignee)

Comment 8

17 years ago
checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Updated

3 months ago
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.