1549146 - Enabling DoH option in UI does not trigger a scrollbar, if there wasn't one

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P1)

Description

[Fanolian]

Attachment: DoH option scrollbar

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0
Build ID: 20190503215639

Steps to reproduce

Please refer to the attached screencast.

1. Make browser window just tall enough so there is not a scrollbar when entering Network Setting, but one should be triggered after enabling DoH, e.g. maximum height on a 1920×1080 monitor, Windows 10 with taskbar visible.
2. Navigate to Nightly's DNS over HTTPS option. Make sure the option is disabled. If not, disable it, click ok and navigate to the option again.
3. ☑Enable DNS over HTTPS. Select Custom for Provider so a new row appears.

Actual result

The custom uri field pushes OK/Cancel/Help buttons out of the option window, making them barely clickable.

Expected result

A scrollbar is triggered. OK/Cancel/Help buttons should be visible at all times.

Workaround

I can still expand the option window and reveal the buttons. But I do not think this is the best option.

Comment 1

[Fanolian]

Similar to bug 1549142, this issue may merely be exposing a bug on how about:preferences UI is constructed. I cannot find another example for such scenario (enable an option -> add a new row) in about:preferences.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

The problem here is that we are showing the Custom textbox and scrolling it into view, but if the dialog doesn't have the "doScroll" class then it won't have the scrollbars.

The code for showing the Custom textbox is at https://hg.mozilla.org/mozilla-central/rev/c7b00a72c46d#l1.179
The code that adds the "doScroll" class is at https://searchfox.org/mozilla-central/source/browser/components/preferences/in-content/subdialogs.js#356

After both showing and hiding the Custom textbox, we should be calling resizeDialog() which will apply the scrollbars if necessary.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549146 - Resize the subdialog after showing/hiding the Custom DoH textbox to make sure scrollbars appear if necessary. r?sfoster

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/036a4b9e8426
Resize the subdialog after showing/hiding the Custom textbox to make sure scrollbars appear if necessary. r=sfoster

Comment 5

[Dorel Luca [:dluca]]

Backed out changeset 036a4b9e8426 (bug 1549146) for Browser-Chrome failures in browser/components/preferences/in-content/tests/browser_connection_dnsoverhttps.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=244907199&repo=autoland&lineNumber=2457

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=036a4b9e84262578b682d6e36ac60416db334d07

Backout:
https://hg.mozilla.org/integration/autoland/rev/70b7703b8c13dc87f02693338eef29ea36bb3689

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f6d0100dec9
Resize the subdialog after showing/hiding the Custom DoH textbox to make sure scrollbars appear if necessary. r=sfoster

Comment 7

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/9f6d0100dec9

Comment 8

[Anca Soncutean, Desktop QA]

Reproduced: Fx 68.0a1 (2019-05-06) - Windows 10 x64
Verified fixed: Fx 69.0a1 (2019-06-05) and Fx 68.0b7 - Windows 10 x64, Ubuntu 18.04 x64, macOS 10.13