1549263 - sliceTimeBudget() has no units

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Description

[Paul Bone [:pbone]]

sliceTimeBudget() should be renamed to sliceTimeBudgetMS() since it's in milliseconds.

https://searchfox.org/mozilla-central/search?q=defaultSliceBudget&path=

Some other symbols will also need to be renamed and comments updated.

Comment 1

[Karan Sapolia]

Hi Paul,
I would like to work on this. May I take this one up? Also, what other symbols will need renaming?

Comment 2

[Paul Bone [:pbone]]

Yes, That's absolutely fine. Feel free to ask any questions.

Comment 3

[Karan Sapolia]

Attachment: Bug 1549263 - Rename sliceTimeBudget() and related symbols to include units. r=pbone

Comment 4

[Paul Bone [:pbone]]

Karan,

Do you have permission to land this with lando yourself? if not you can set the checkin-needed keyword on the bug and a sheriff will do it for you.

Thanks.

Comment 5

[Karan Sapolia]

(In reply to Paul Bone [:pbone] from comment #4)

Karan,

Do you have permission to land this with lando yourself? if not you can set the checkin-needed keyword on the bug and a sheriff will do it for you.

Thanks.

Not yet. I will have to learn how to request commit access and know what level of access can I request for. Have set the keyword in the bug. Thank you for the review :)

Comment 6

[Paul Bone [:pbone]]

I think there's only one level you can have initially, which gives you access to the try servers but not inbound. I don't know how it works with autoland I'm afraid.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/45344eeb154d
Rename sliceTimeBudget() and related symbols to include units. r=pbone

Comment 8

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/45344eeb154d