Closed Bug 1549265 Opened 6 months ago Closed 5 months ago

No units are provided for MarkStack::capacity() and similar symbols

Categories

(Core :: JavaScript: GC, task, P3)

task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox69 --- fixed

People

(Reporter: pbone, Assigned: sapoliakaran, Mentored)

Details

Attachments

(1 file)

No units are provided for MarkStack::capacity() and similar symbols, including the JSGC_MARK_STACK_LIMIT gcparam. The unit used is mark stack entries.

Hi Karan,

You asked if there were other renaming bugs you could work on. This is the other one that I know of.

Finding a good name is tricker here since the mark stack is just measured in how many items it can store, not bytes or anything like that. If you can think of a good name that's great. But might be simplier just to add a comment on the mark stack or marker classes.

Thanks.

Flags: needinfo?(sapoliakaran)

Sure Paul.
Let me take a look at the code and start working on these bugs. I'll see if I can come up with a good name. I'll reach out to you when I have queries. Thank you.

Flags: needinfo?(sapoliakaran)
Assignee: nobody → sapoliakaran
Mentor: pbone
Status: NEW → ASSIGNED

Karan, Setting the checkin-needed flag on this bug too ;-)

Keywords: checkin-needed

Pushed by aiakab@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2d20a5cf362a
Add comment to explain unit of MarkStack::capacity(). r=pbone

Keywords: checkin-needed

(In reply to Paul Bone [:pbone] from comment #4)

Karan, Setting the checkin-needed flag on this bug too ;-)

Oh, I forgot! Thank you! :)

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69
You need to log in before you can comment on or make changes to this bug.