1549290 - Add support for addon_signature "curated" in AbuseReport

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, task, P2)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

As part of the integrated Add-ons Abuse Report, "curated" extensions should have the addon_signature property set as "curated" (See https://addons-server.readthedocs.io/en/latest/topics/api/abuse.html#abuse-addon-signature-parameter)

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1549290 - Set AbuseReport addon_signature as "curated" in AbuseReport on recommended addon. r?robwu!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8173964751e0
Set AbuseReport addon_signature as "curated" in AbuseReport on recommended addon. r=robwu,aswan

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/8173964751e0

Comment 4

[Victor Carciu]

Verified as fixed in Firefox Nightly 69.0a1 (2019-06-13) (64-bit) using Win10x64 and macOS 10.14.5

Please see postfix screenshot attached

Comment 5

[Victor Carciu]

Attachment: Postfix Screenshot

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 9071845 [details]
Bug 1549290 - Set AbuseReport addon_signature as "curated" in AbuseReport on recommended addon. r?robwu!

Beta/Release Uplift Approval Request

• User impact if declined: No visible impact, the user would still be able to submit an abuse report for a recommended extension even without this change.
  The main difference would be that with this change the addon_signature property submitted to the API endpoint would be set to "curated".
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Same STR used to verify it on Nightly
• List of other uplifts needed: Bug 1558305, Bug 1558784, Bug 1540253
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Not risky, as it is a very small incremental change, restricted to AbuseReporter.jsm, covered by existing test case and a new one included in the same patch.
• String changes made/needed:

Comment 7

[Luca Greco [:rpl] [:luca] [:lgreco]]

(In reply to Luca Greco [:rpl] from comment #6)

• List of other uplifts needed: Bug 1558305, Bug 1558784, Bug 1540253

Bug 1558305 and Bug 1558784 have their own separate uplift requests (but I mentioned them explicitly as this change has been applied on Nightly on top of those two changes).

Bug 1540253 provides the new addon.isRecommended property that is used in this patch to recognize a recommended extension.

Comment 8

[Julien Cristau [:jcristau]]

Comment on attachment 9071845 [details]
Bug 1549290 - Set AbuseReport addon_signature as "curated" in AbuseReport on recommended addon. r?robwu!

approved for 68.0b11

Comment 9

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f0aba1f30d06

Comment 10

[Victor Carciu]

Verified the uplift in FF 68.0b11 (64-bit) on Windows 10x64 and macOS 10.14.5 and everything looks fine.

Marking bug as verified for 68