1549334 - Nigthly in product pages use Firefox release branding, should use Nightly one (e.g. in onboarding, on about:firefox)

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Firefox Nightly 68.0a1 20190505 (aarch) on Android 9.0

The onboarding screen when one launches Firefox the first time and also about:fiefox use the official Firefox logo reserved for release and beta. about:buildconfig says the nightly branding gets used and MOZ_OFFICIAL set to 1. On the home screen, it's the correct Nightly logo.

Are caches/artifacts involved?

Comment 1

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

(In reply to Sebastian Hengst [:aryx] (needinfo on intermittent or backout) from comment #0)

Firefox Nightly 68.0a1 20190505 (aarch) on Android 9.0

The onboarding screen when one launches Firefox the first time and also about:fiefox use the official Firefox logo reserved for release and beta. about:buildconfig says the nightly branding gets used and MOZ_OFFICIAL set to 1. On the home screen, it's the correct Nightly logo.

Are caches/artifacts involved?

Probably not: there are two types of resources being used. One is the regular Gecko/XUL HTML/CSS/JS flow which is used in about:firefox; from what you say, that's not working fine. The other is the Android XML/PNG resources flow which is used for the home screen icon, etc; from what you say that's working fine.

Digging in, I see that it's simply about:firefox uses https://searchfox.org/mozilla-central/source/mobile/android/themes/core/images/logo-hdpi.png for the "logo" element (see https://searchfox.org/mozilla-central/source/mobile/android/themes/core/aboutPage.css#40) and that image isn't subject to branding.

I doubt we care about this enough to address it for Fennec.

I don't see the onboarding screen usage that you see; that's all done in native Android UI and appears to have Nightly branding. Screenshot?

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: onboarding nightly screenshot

Comment 3

[Nick Alexander :nalexander [he/him] (PTO August 22-September 12)]

Aryx: is this a -multi APK (i.e., from Google Play) or a de single-locale repack?

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The multilocale apk. buildconfig also mentions aach64-unknown-linux-android.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.