Closed
Bug 1549416
Opened 6 years ago
Closed 6 years ago
Android 64b build failing
Categories
(NSPR :: NSPR, enhancement, P1)
Tracking
(firefox68 affected)
RESOLVED
FIXED
4.22
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | affected |
People
(Reporter: eoger, Assigned: eoger)
References
Details
Attachments
(1 file, 1 obsolete file)
|
1.09 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
Patch incoming
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9062982 -
Flags: review?(jjones)
|
||
Updated•6 years ago
|
Severity: normal → critical
status-firefox68:
--- → affected
OS: Unspecified → Android
Priority: -- → P1
|
|
Assignee | |
Comment 3•6 years ago
|
||
My bad it was wrongly categorized
Type: defect → enhancement
Flags: needinfo?(eoger)
|
|
||
Comment 4•6 years ago
|
||
Comment on attachment 9062982 [details] [diff] [review]
bug-1549416.patch
Review of attachment 9062982 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good to me, but I'm not a peer on NSPR. Mike, could you take a look? Feel free to ni? me to land it.
Attachment #9062982 -
Flags: review?(mh+mozilla)
Attachment #9062982 -
Flags: review?(jjones)
Attachment #9062982 -
Flags: review+
|
||
Comment 5•6 years ago
|
||
Comment on attachment 9062982 [details] [diff] [review]
bug-1549416.patch
Review of attachment 9062982 [details] [diff] [review]:
-----------------------------------------------------------------
You need to change configure.in too.
Attachment #9062982 -
Flags: review?(mh+mozilla) → review-
|
|
Assignee | |
Comment 6•6 years ago
|
||
Done
Attachment #9062982 -
Attachment is obsolete: true
Attachment #9063098 -
Flags: review?(mh+mozilla)
|
|
||
Updated•6 years ago
|
Attachment #9063098 -
Flags: review?(mh+mozilla) → review+
|
|
||
Comment 7•6 years ago
|
||
Is there a particular reason you didn't you phabricator, btw?
|
|
Assignee | |
Comment 8•6 years ago
|
||
phlay couldn't find an .arcconfig in the repo, I didn't look very hard so I just assumed there was no phabricator support.
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
|
|
||
Comment 9•6 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.22
You need to log in
before you can comment on or make changes to this bug.
Description
•