Android 64b build failing

RESOLVED FIXED in 4.22

Status

Product:
NSPR
Component:
NSPR
Type:
enhancement
Importance:
P1
critical
Status:
RESOLVED FIXED
Opened:
3 months ago
Updated:
22 days ago

People

(Reporter: eoger, Assigned: eoger)

Tracking

(Blocks 1 bug)

Version:
4.21
Target:
4.22
Platform:
Unspecified
Android
Dependency tree / graph

Firefox Tracking Flags

(firefox68 affected)

Details

Attachments

(1 attachment, 1 obsolete attachment)

bug-1549416.patch
1.09 KB, patch
glandium
: review+
Details | Diff | Splinter Review

Patch incoming

Posted patch bug-1549416.patch (obsolete) — — Splinter Review
Attachment #9062982 - Flags: review?(jjones)
Severity: normal → critical
status-firefox68: --- → affected
OS: Unspecified → Android
Priority: -- → P1

Is this is a regression, Edouard?

Flags: needinfo?(eoger)

My bad it was wrongly categorized

Type: defect → enhancement
Flags: needinfo?(eoger)
Comment on attachment 9062982 [details] [diff] [review]
bug-1549416.patch

Review of attachment 9062982 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but I'm not a peer on NSPR. Mike, could you take a look? Feel free to ni? me to land it.
Attachment #9062982 - Flags: review?(mh+mozilla)
Attachment #9062982 - Flags: review?(jjones)
Attachment #9062982 - Flags: review+
Comment on attachment 9062982 [details] [diff] [review]
bug-1549416.patch

Review of attachment 9062982 [details] [diff] [review]:
-----------------------------------------------------------------

You need to change configure.in too.
Attachment #9062982 - Flags: review?(mh+mozilla) → review-

Done

Attachment #9062982 - Attachment is obsolete: true
Attachment #9063098 - Flags: review?(mh+mozilla)
Attachment #9063098 - Flags: review?(mh+mozilla) → review+

Is there a particular reason you didn't you phabricator, btw?

phlay couldn't find an .arcconfig in the repo, I didn't look very hard so I just assumed there was no phabricator support.

Keywords: checkin-needed

https://hg.mozilla.org/projects/nspr/rev/4d940761b90a7a6833a2860de84f940b8856af15

Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.22
Blocks: 1562330
You need to log in before you can comment on or make changes to this bug.