Closed Bug 1549416 Opened 2 years ago Closed 2 years ago

Android 64b build failing

Categories

(NSPR :: NSPR, enhancement, P1)

4.21
Unspecified
Android
enhancement

Tracking

(firefox68 affected)

RESOLVED FIXED
Tracking Status
firefox68 --- affected

People

(Reporter: eoger, Assigned: eoger)

References

Details

Attachments

(1 file, 1 obsolete file)

Patch incoming

Attached patch bug-1549416.patch (obsolete) — Splinter Review
Attachment #9062982 - Flags: review?(jjones)
Severity: normal → critical
OS: Unspecified → Android
Priority: -- → P1

Is this is a regression, Edouard?

Flags: needinfo?(eoger)

My bad it was wrongly categorized

Type: defect → enhancement
Flags: needinfo?(eoger)
Comment on attachment 9062982 [details] [diff] [review]
bug-1549416.patch

Review of attachment 9062982 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, but I'm not a peer on NSPR. Mike, could you take a look? Feel free to ni? me to land it.
Attachment #9062982 - Flags: review?(mh+mozilla)
Attachment #9062982 - Flags: review?(jjones)
Attachment #9062982 - Flags: review+
Comment on attachment 9062982 [details] [diff] [review]
bug-1549416.patch

Review of attachment 9062982 [details] [diff] [review]:
-----------------------------------------------------------------

You need to change configure.in too.
Attachment #9062982 - Flags: review?(mh+mozilla) → review-

Done

Attachment #9062982 - Attachment is obsolete: true
Attachment #9063098 - Flags: review?(mh+mozilla)
Attachment #9063098 - Flags: review?(mh+mozilla) → review+

Is there a particular reason you didn't you phabricator, btw?

phlay couldn't find an .arcconfig in the repo, I didn't look very hard so I just assumed there was no phabricator support.

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 4.22
Blocks: 1562330
You need to log in before you can comment on or make changes to this bug.