Closed Bug 1549435 Opened 5 years ago Closed 4 months ago

[meta] Page.getFrameTree

Categories

(Remote Protocol :: CDP, task)

task

Tracking

(Not tracked)

RESOLVED WORKSFORME

People

(Reporter: ato, Unassigned)

References

()

Details

(Keywords: meta, Whiteboard: [method=Page.getFrameTree])

No description provided.
Depends on: 1549384
Keywords: meta
Whiteboard: [method=Page.getFrameTree]

This is called when Puppeteer initializes the FrameManager, which is always present:
https://github.com/GoogleChrome/puppeteer/blob/master/lib/FrameManager.js#L61

We actually have this API implemented but don't return all the required properties. In _handleFrameTree it needs at least also the parentId, and childFrames. Both aren't used right now. Maybe also other properties are needed somewhere else.

https://github.com/GoogleChrome/puppeteer/blob/master/lib/FrameManager.js#L175-L184

Whiteboard: [method=Page.getFrameTree] → [method=Page.getFrameTree][puppeteer-alpha]

(In reply to Henrik Skupin (:whimboo) [⌚️UTC+2] from comment #1)

We actually have this API implemented but don't return all the required properties. In _handleFrameTree it needs at least also the parentId, and childFrames. Both aren't used right now. Maybe also other properties are needed somewhere else.

Both properties have been implemented now with my patch on bug 1605359. All the others don't seem to be relevant to Puppeteer, and as such are not implemented yet. We would have to follow-up with those additions at a later time (if necessary at all).

No longer blocks: 1605499
Whiteboard: [method=Page.getFrameTree][puppeteer-alpha] → [method=Page.getFrameTree]
Component: CDP: Page → CDP
Severity: normal → S3

Everything that we could do for this API is done.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.