1549442 - Picture-in-Picture toggle does not collapse or disappear if the mouse moves outside of the window.

Status: VERIFIED FIXED

(Toolkit :: Video/Audio Controls, defect, P2)

Description

[Alice0775 White]

Attachment: image.png

Steps to reproduce:

1. Open https://www.mozilla.org/en-US/developer/
2. Scroll to bottom
3. Scroll to "Videos to watch"
4. Playbacj the video
5. Move mouse pointer over the video, And then move the mouse outside of the video
   --- observe, Picture-and-Picture toggle would not disappear
6. Repeat step 5 if necessary

Actual Results:
Picture-and-Picture toggle would not disappear.
Even if video controls are hidden, the toggles is staying over the video forever.

Expected Results:
Picture-in-Picture toggle should not display when mouse pointer is outside of video.

Comment 1

[Alice0775 White]

s/4. Playbacj/4. Playback/

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Needinfo for PiP triage.

Comment 3

[Alice0775 White]

Another Steps to reproduce:

1. Open https://www.nicovideo.jp/watch/1558058343
2. Start playback
3. Click on Full screen button in video controls
4. Move mouse pointer over video
   --- the PiP toggle button appears as expected
5. Move mouse pointer outside of video
   --- the PiP toggle button is staying forever --- BUG!

Comment 4

[Mike Conley (:mconley) (:⚙️)]

This will be improved somewhat once bug 1566152 is closed.

Comment 5

[Fanolian]

I can confirm toggle buttons no longer stay indefinitely in various cases after bug 1566152.

Comment 6

[Alice0775 White]

I can still reproduce the issue.

Build ID 20190720214009
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:70.0) Gecko/20100101 Firefox/70.0

Steps to reproduce:

1. Browser unmaximized
2. Open https://www.nicovideo.jp/watch/1558058343
3. Start playback
4. Click on Full screen button in video controls
5. Move mouse pointer over video
   --- the PiP toggle button appears as expected
6. Mouse hover over the PiP toggle button
7. Move mouse pointer to the right so that mouse pointer will be outside of browser
   --- the PiP toggle button is staying forever --- BUG!

Comment 7

[Alice0775 White]

Attachment: screencast, bug appears

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1549442 - Make sure to hide the Picture-in-Picture toggle when the mouse cursor leaves the window. r?JSON_Voorhees

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5bad9f31e57f
Make sure to hide the Picture-in-Picture toggle when the mouse cursor leaves the window. r=JSON_voorhees

Comment 11

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/5bad9f31e57f

Comment 13

[Cristian Craciun]

Build ID 20191022214314
User Agent Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:72.0) Gecko/20100101 Firefox/72.0

Verified as fixed on the latest Nightly build on Windows 10.