1549460 - [meta] Network.setCacheDisabled

Status: RESOLVED FIXED

(Remote Protocol :: CDP, task)

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Seems to be used in Puppeteer for HTTP authentications. But I cannot find an instance of a call to authenticate() from inside the Gutenberg tests. It's not clear right now if it is needed or not for the alpha release. I won't add it for now as blocker.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Juggler uses the following code:

setCacheDisabled({cacheDisabled}) {
    const enable = Ci.nsIRequest.LOAD_NORMAL;
    const disable = Ci.nsIRequest.LOAD_BYPASS_CACHE |
                  Ci.nsIRequest.INHIBIT_CACHING;

    const docShell = this._frameTree.mainFrame().docShell();
    docShell.defaultLoadFlags = cacheDisabled ? disable : enable;
  }

I wonder if that persists navigation requests. Also what is the lifetime of the docshell? I assume until the unload?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Currently this missing API is causing a lot of Puppeteer unit tests to fail. I will have a look if we can get the above code from Juggler quickly implemented.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With bug 1607461 everything should have been implemented.