Closed Bug 1549495 Opened 5 years ago Closed 4 months ago

[meta] Runtime.evaluate

Categories

(Remote Protocol :: CDP, task)

Product:
Remote Protocol
Component:
CDP
Type:
task

Tracking

(Not tracked)

Status:
RESOLVED WORKSFORME

People

(Reporter: ato, Unassigned)

References

(
URL
)

Details

(Keywords: meta, Whiteboard: [method=Runtime.evaluate])

No description provided.
Blocks: puppeteer-mvp, puppeteer
URL: https://chromedevtools.github.io/devt...
Depends on: 1543099
Keywords: meta
Whiteboard: [method=Runtime.evaluate]
Depends on: 1548480
Depends on: 1553756

With the basic implementation only 2 (expression, and contextId) out of 13 arguments are supported. But Puppeteer uses more arguments when calling this CDP API:

        expression: expressionWithSourceUrl,
        contextId,
        returnByValue,
        awaitPromise: true,
        userGesture: true

I assume that we at least need support for returnByValue and awaitPromise for the Gutenberg tests (alpha release).

Blocks: puppeteer-gutenberg
Whiteboard: [method=Runtime.evaluate] → [method=Runtime.evaluate][puppeteer-alpha]
Whiteboard: [method=Runtime.evaluate][puppeteer-alpha] → [method=Runtime.evaluate]
Component: CDP: Runtime → CDP
Severity: normal → S3

Everything that we could do for this API is done.

Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → WORKSFORME
No longer depends on: 1650112
You need to log in before you can comment on or make changes to this bug.