Closed Bug 1549537 Opened 5 months ago Closed 5 months ago

"Span" option for "Set as Desktop Background" no longer offered on Linux

Categories

(Firefox :: Shell Integration, defect, minor)

Unspecified
Linux
defect
Not set
minor

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: Kwan, Assigned: Kwan)

References

(Regression)

Details

Attachments

(1 file)

Bug 1544105 added a default implementation of GfxInfoBase::FindMonitors, so now gfxInfo.getMonitors() no longer throws on Linux, which the set as desktop background code was relying on [0]. It should be changed to a platform check instead.

[0] https://searchfox.org/mozilla-central/rev/e7d9a8749303b39dadcc0e18ea0d60a570a68145/browser/components/shell/content/setDesktopBackground.js#39

Bug 1544105 added a default implementation of GfxInfoBase::FindMonitors so
gfxInfo.getMonitors() no longer throws on Linux, but it only ever returns the
primary monitor there.

Apologies, and thanks for fixing this.

No worries, I perhaps should have just done the platform check in the first place, rather than relying on throwing.

Thanks sfoster (and jaws)

Sheriffs, this is for both this and bug 1547459.
Green try for linux64 (build failure is expected "pushed before central generated artefacts" fail):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=02aa60758bf952b114ddb112d7c8c392e41600ad

Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1b84518177e7
Unconditionally offer 'Span' option for desktop background position on Linux. r=sfoster

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.