Make search initialization failure more obvious

RESOLVED FIXED in Firefox 68

Status

()

defect
P1
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: aswan, Assigned: aswan)

Tracking

unspecified
Firefox 68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

Attachments

(1 attachment)

We have a whole slew of bugs surrounding search service initialization and they have all been very difficult to debug. Some of these may be outright races, but it also appears from inspection that some of the code in SearchService._init() could leave the search service in a difficult-to-debug state if something throws an Exception.

The search service is already written to have separate states for successful and unsuccessful initialization:
https://searchfox.org/mozilla-central/rev/b2015fdd464f598d645342614593d4ebda922d95/toolkit/components/search/SearchService.jsm#701-707

This patch is only meant to ensure that we get into the "unsuccessfully initialized state" if something throws during initialization and add some additional logging in that case.

Status: NEW → ASSIGNED
Priority: -- → P1
Pushed by aswan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6ad2b2b28add
Make search initialization failures more obvious r=Gijs
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.