Make search initialization failure more obvious
Categories
(Firefox :: Search, defect, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: aswan, Assigned: aswan)
Details
Attachments
(1 file)
We have a whole slew of bugs surrounding search service initialization and they have all been very difficult to debug. Some of these may be outright races, but it also appears from inspection that some of the code in SearchService._init() could leave the search service in a difficult-to-debug state if something throws an Exception.
The search service is already written to have separate states for successful and unsuccessful initialization:
https://searchfox.org/mozilla-central/rev/b2015fdd464f598d645342614593d4ebda922d95/toolkit/components/search/SearchService.jsm#701-707
This patch is only meant to ensure that we get into the "unsuccessfully initialized state" if something throws during initialization and add some additional logging in that case.
|
Assignee | |
Comment 1•2 years ago
|
||
|
||
Updated•2 years ago
|
Pushed by aswan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ad2b2b28add Make search initialization failures more obvious r=Gijs
|
||
Comment 3•2 years ago
|
||
| bugherder | ||
Description
•