Closed Bug 1549554 Opened 1 year ago Closed 1 year ago

Use biplist for plist parsing

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: kats, Assigned: kats)

References

Details

Attachments

(1 file)

I bit the bullet and updated to macOS 10.14 today and ran into various issues that have been previously described in bug 1522931, bug 1544418, bug 1487552, etc.

One of the sub-problems I ran into while trying to get a working build was that I added this to my mozconfig:

ac_add_options --with-macos-sdk=$(xcrun --sdk macosx --show-sdk-path)

which ends up setting --with-macos-sdk to the 10.14 SDK. The 10.14 SDK has a binary SDKSettings.plist file (as mentioned in bug 1522931 comment 6). The patches in that bug vendored biplist which can read this binary plist, but the second patch (which updated the configure code to actually use biplist) got backed out because it did a few other quasi-unrelated things that broke people's builds.

So now we're in a state where we have biplist vendored, but aren't using it, and so the 10.14 SDK's SDKSettings.plist file cannot be read. If we switch to using biplist this problem goes away and I don't think it should break anything else, because biplist can also parse old non-binary plist files.

Oh hmm maybe it can't read the old non-binary plist files? I tested that incorrectly and now I'm not sure.

Verified by downloading the 10.13 SDK from https://github.com/phracker/MacOSX-SDKs/releases/download/10.13/MacOSX10.13.sdk.tar.xz and pointing --with-macos-sdk to that SDK. Application of this patch goes through the relevant code and doesn't fail configure.

Pushed by kgupta@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c5289f88fb4
Use biplist instead of plistlib so we can parse SDKSettings.plist in the 10.14 SDK. r=firefox-build-system-reviewers,mshal
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.