Closed Bug 1549576 Opened 7 months ago Closed 7 months ago

NullPointerException in GeckoDisplay.setVerticalClipping when setting new session

Categories

(GeckoView :: General, defect, P1)

68 Branch
Unspecified
All
defect

Tracking

(geckoview66 wontfix, firefox-esr60 wontfix, firefox66 wontfix, firefox67 ?, firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
geckoview66 --- wontfix
firefox-esr60 --- wontfix
firefox66 --- wontfix
firefox67 --- ?
firefox68 --- fixed

People

(Reporter: csadilek, Assigned: eeejay)

Details

(Whiteboard: [geckoview:fenix:m6])

Attachments

(1 file)

We're running into crashes with the new setVerticalClipping introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=1516048.

This happens in all cases where we assign a new session to an existing view.

Relevant stack trace:

java.lang.NullPointerException: NullHandle
at org.mozilla.geckoview.GeckoSession$Compositor.setFixedBottomOffset(Native Method)
at org.mozilla.geckoview.GeckoDisplay.setVerticalClipping(GeckoDisplay.java:122)
at org.mozilla.geckoview.GeckoView$Display.setVerticalClipping(GeckoView.java:180)
at org.mozilla.geckoview.GeckoView$Display.acquire(GeckoView.java:114)
at org.mozilla.geckoview.GeckoView.setSession(GeckoView.java:390)
at org.mozilla.geckoview.GeckoView.setSession(GeckoView.java:353)

Issue in Android Components: https://github.com/mozilla-mobile/android-components/issues/2935

Assignee: nobody → eitan
Priority: -- → P1
Whiteboard: [geckoview:fenix:p1]
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/45f82a11656c
Store fixed layer margin in session and send to compositor when ready. r=geckoview-reviewers,snorp

Backed out changeset 45f82a11656c (Bug 1549576) for GeckoSession.java related checkstyle failures

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=android%2C4.0%2Capi16%2B%2Copt%2Candroid%2Cgradle%2Ctests%2Cbuild-android-checkstyle%2Fopt%2Ca%28checkstyle%29&fromchange=4bbf8907a6d8c2b7b689f83b55c5ccd892f19cfc&tochange=1a5f757dd6f90e8a30f81e1131b2f7226a651957&selectedJob=245165883

Backout link: https://hg.mozilla.org/integration/autoland/rev/1a5f757dd6f90e8a30f81e1131b2f7226a651957

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245165883&repo=autoland&lineNumber=2809

[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - Execution failed for task ':geckoview:checkstyleWithGeckoBinariesDebug'.
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - > Checkstyle rule violations were found. See the report at: file:///builds/worker/workspace/build/src/obj-firefox/gradle/build/mobile/android/geckoview/reports/checkstyle/withGeckoBinariesDebug.html
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - Checkstyle files with violations: 1
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - Checkstyle violations by severity: [error:1]
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - * Try:
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - * Get more help at https://help.gradle.org
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - Use '--warning-mode all' to show the individual deprecation warnings.
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - See https://docs.gradle.org/4.10.2/userguide/command_line_interface.html#sec:command_line_warnings
[task 2019-05-07T18:08:34.253Z] 18:08:34 INFO - BUILD FAILED in 12s
[task 2019-05-07T18:08:34.254Z] 18:08:34 INFO - 12 actionable tasks: 2 executed, 10 up-to-date
[task 2019-05-07T18:08:34.752Z] 18:08:34 INFO - SUITE-START | android-checkstyle
[task 2019-05-07T18:08:34.832Z] 18:08:34 INFO - TinderboxPrint: report<br/><a href="https://queue.taskcluster.net/v1/task/WlkJTyWmRTCmoaAk7AhCYg/runs/0/artifacts/public/android/checkstyle">HTML checkstyle report</a>, visit "Inspect Task" link for details
[task 2019-05-07T18:08:34.832Z] 18:08:34 INFO - TinderboxPrint: report<br/><a href="https://queue.taskcluster.net/v1/task/WlkJTyWmRTCmoaAk7AhCYg/runs/0/artifacts/public/android/checkstyle">XML checkstyle report</a>, visit "Inspect Task" link for details
[task 2019-05-07T18:08:34.832Z] 18:08:34 INFO - TEST-UNEXPECTED-FAIL | android-checkstyle | Checkstyle rule violations were found. See the report at: https://queue.taskcluster.net/v1/task/WlkJTyWmRTCmoaAk7AhCYg/runs/0/artifacts/public/android/checkstyle
[task 2019-05-07T18:08:34.832Z] 18:08:34 INFO - TEST-UNEXPECTED-FAIL | /builds/worker/workspace/build/src/mobile/android/geckoview/src/main/java/org/mozilla/geckoview/GeckoSession.java
[task 2019-05-07T18:08:34.832Z] 18:08:34 INFO - TEST-UNEXPECTED-FAIL | <error column="45" line="4754" message="Parameter offset should be final." severity="error" source="com.puppycrawl.tools.checkstyle.checks.FinalParametersCheck" />
[task 2019-05-07T18:08:34.842Z] 18:08:34 INFO - SUITE-END | android-checkstyle
[task 2019-05-07T18:08:34.863Z] 18:08:34 ERROR - Return code: 1
[task 2019-05-07T18:08:34.864Z] 18:08:34 ERROR - 1 not in success codes: [0]
[task 2019-05-07T18:08:34.864Z] 18:08:34 WARNING - setting return code to 2
[task 2019-05-07T18:08:34.864Z] 18:08:34 FATAL - Halting on failure while running ['/builds/worker/workspace/build/src/obj-x86_64-pc-linux-gnu/_virtualenvs/init/bin/python', 'mach', '--log-no-times', 'android', 'checkstyle']
[task 2019-05-07T18:08:34.864Z] 18:08:34 FATAL - Running post_fatal callback...
[task 2019-05-07T18:08:34.864Z] 18:08:34 FATAL - Exiting 2
[task 2019-05-07T18:08:34.864Z] 18:08:34 INFO - [mozharness: 2019-05-07 18:08:34.864194Z] Finished build step (failed)
[task 2019-05-07T18:08:34.864Z] 18:08:34 INFO - Running post-run listener: _parse_build_tests_ccov
[task 2019-05-07T18:08:34.864Z] 18:08:34 INFO - Running post-run listener: _shutdown_sccache
[task 2019-05-07T18:08:34.864Z] 18:08:34 INFO - Running post-run listener: _summarize
[task 2019-05-07T18:08:34.864Z] 18:08:34 ERROR - # TBPL FAILURE #
[task 2019-05-07T18:08:34.864Z] 18:08:34 INFO - [mozharness: 2019-05-07 18:08:34.864401Z] FxDesktopBuild summary:
[task 2019-05-07T18:08:34.864Z] 18:08:34 ERROR - # TBPL FAILURE #
[taskcluster 2019-05-07 18:08:35.378Z] === Task Finished ===
[taskcluster 2019-05-07 18:08:38.319Z] Unsuccessful task run with exit code: 2 completed in 313.643 seconds

Flags: needinfo?(eitan)
Pushed by eisaacson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c8c1f93843a
Store fixed layer margin in session and send to compositor when ready. r=geckoview-reviewers,snorp
Whiteboard: [geckoview:fenix:p1] → [geckoview:fenix:m6]
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: needinfo?(eitan)
You need to log in before you can comment on or make changes to this bug.