1549580 - Fission: Crash in [@ mozilla::dom::ClientSource::SetController]

Status: RESOLVED DUPLICATE of bug 1535699

(Core :: DOM: Content Processes, defect, P3)

Description

[Darkspirit]

Mozregression STR: Play the video and open a second tab: https://youtu.be/5JNgC8tc-x8

mozregression --good 2019-05-01 --bad 2019-05-06 --pref fission.autostart:true -a https://www.youtube.com/watch?v=_fuIMye31Gw

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=c7a5a7b9cd50eff1be7591a5c49ee1164d800349&tochange=7f0dd201e0593edb157189e0952f8def5e387f11

Nika Layzell — Bug 1544811 - Use web processes on a per-site basis for fission-enabled windows, r=mconley

This bug is for crash report bp-0a3cad26-029e-4145-9815-f06ab0190506.

Top 10 frames of crashing thread:

0 libxul.so mozilla::dom::ClientSource::SetController dom/clients/manager/ClientSource.cpp:362
1 libxul.so nsGlobalWindowInner::EnsureClientSource dom/base/nsGlobalWindowInner.cpp:1778
2 libxul.so nsGlobalWindowOuter::SetNewDocument dom/base/nsGlobalWindowOuter.cpp:2226
3 libxul.so nsDocumentViewer::InitInternal layout/base/nsDocumentViewer.cpp:966
4 libxul.so nsDocumentViewer::Init layout/base/nsDocumentViewer.cpp:717
5 libxul.so nsDocShell::Embed docshell/base/nsDocShell.cpp:6339
6 libxul.so nsDSURIContentListener::DoContent docshell/base/nsDSURIContentListener.cpp:183
7 libxul.so nsDocumentOpenInfo::TryContentListener uriloader/base/nsURILoader.cpp:748
8 libxul.so nsDocumentOpenInfo::OnStartRequest uriloader/base/nsURILoader.cpp:299
9 libxul.so mozilla::net::HttpChannelChild::DoOnStartRequest netwerk/protocol/http/HttpChannelChild.cpp:680

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The priority flag is not set for this bug.
:jimm, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 2

[Jeff Muizelaar [:jrmuizel]]

I was able to reliably able to reproduce this by opening a twitter link from gmail.

Comment 3

[Neha Kochar [:neha]]

I'm able to reproduce with some (but not all) twitter links from gmail.

Andrew, can you look into this?

Comment 4

[Gian-Carlo Pascutto [:gcp]]

I get an immediate crash with this signature on http://www.hln.be (with adblockers disabled).

Comment 5

[Andrew McCreight [:mccr8]]

These crashes are all:
MOZ_RELEASE_ASSERT(ClientMatchPrincipalInfo(mClientInfo.PrincipalInfo(), aServiceWorker.PrincipalInfo()))
Oddly these are happening (in much lower volume) even in versions earlier than 69.

It looks like this is service worker related, so maybe it would make more sense for Andrew to at least give an initial assessment? Are service workers expected to work with Fission?