Closed Bug 1549593 Opened 5 months ago Closed 5 months ago

Use OwnedSlice more.

Categories

(Core :: CSS Parsing and Computation, task, P3)

task

Tracking

()

RESOLVED FIXED

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

May end up replacing it with ThinVec, but it'd be trivial either way after this patch, and I wrote more stuff on top of this.

This is just a refactor in the right direction. Eventual goal is:

  • All inherited properties use ArcSlice<>.
  • All reset properties use OwnedSlice<> (or ThinVec<>).

No conversion happens at all, so we can remove all that glue, and also
compute_iter and co.

Of course there's work to do, but this is a step towards that.

Depends on D30126

Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f419e689abf0
Move OwnedSlice to style_traits. r=heycam
Keywords: leave-open
Blocks: 1550554
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/2e4b263c9410
Use OwnedSlice in the specified and computed values of most vector properties. r=heycam

New failure "Assertion failure: _0.ptr->data.header.header == kArcSliceCanary (Uh?), at z:/build/build/src/obj-firefox/dist/include\mozilla/ServoStyleConstsInlines.h:118"

Failure link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246826943&repo=autoland&lineNumber=993

New failure "Assertion failure: _0.ptr->data.header.header == kArcSliceCanary (Uh?), at z:/build/build/src/obj-firefox/dist/include\mozilla/ServoStyleConstsInlines.h:118"

Failure link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=246826943&repo=autoland&lineNumber=993

See bug 1550554 comment 11 for the explanation.

Flags: needinfo?(emilio)
Type: defect → task
Priority: -- → P3
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7321594dab26
Use OwnedSlice in the specified and computed values of most vector properties. r=heycam
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.