Closed Bug 1549596 Opened 2 years ago Closed 2 years ago

Minor servo_arc cleanups.

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files, 1 obsolete file)

Bug 1549596 - ThinArc should use NonNull. r=bholley,heycam
47 bytes, text/x-phabricator-request
Details | Review
Bug 1549596 - Use PhantomData<T> in servo_arc. r=bholley,heycam
47 bytes, text/x-phabricator-request
Details | Review
No description provided.

This code seemed suspicious when I was reading it, and apparently I was right.
StdArc also has the PhantomData<T>:

https://doc.rust-lang.org/stable/src/alloc/sync.rs.html#193-196

This doesn't make anything not compile, which I guess means we were not doing
anything unsound.

If only for parallelism with Arc<>.

Depends on D30130

Attachment #9063074 - Attachment is obsolete: true
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48edd877bde3
ThinArc should use NonNull. r=bholley
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63d77dbcfda8
Use PhantomData<T> in servo_arc. r=bholley

https://hg.mozilla.org/mozilla-central/rev/48edd877bde3
https://hg.mozilla.org/mozilla-central/rev/63d77dbcfda8

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.