1549596 - Minor servo_arc cleanups.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1549596 - Get variance right in servo_arc. r=bholley,heycam

This code seemed suspicious when I was reading it, and apparently I was right.
StdArc also has the PhantomData<T>:

https://doc.rust-lang.org/stable/src/alloc/sync.rs.html#193-196

This doesn't make anything not compile, which I guess means we were not doing
anything unsound.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1549596 - ThinArc should use NonNull. r=bholley,heycam

If only for parallelism with Arc<>.

Depends on D30130

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1549596 - Use PhantomData<T> in servo_arc. r=bholley,heycam

See https://github.com/rust-lang/rust/pull/60594#issuecomment-489966933

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/48edd877bde3
ThinArc should use NonNull. r=bholley

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63d77dbcfda8
Use PhantomData<T> in servo_arc. r=bholley

Comment 6

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/48edd877bde3
https://hg.mozilla.org/mozilla-central/rev/63d77dbcfda8