Closed
Bug 1549596
Opened 6 years ago
Closed 6 years ago
Minor servo_arc cleanups.
Categories
(Core :: CSS Parsing and Computation, defect)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla68
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files, 1 obsolete file)
No description provided.
Assignee | ||
Comment 1•6 years ago
|
||
This code seemed suspicious when I was reading it, and apparently I was right.
StdArc also has the PhantomData<T>:
https://doc.rust-lang.org/stable/src/alloc/sync.rs.html#193-196
This doesn't make anything not compile, which I guess means we were not doing
anything unsound.
Assignee | ||
Comment 2•6 years ago
|
||
If only for parallelism with Arc<>.
Depends on D30130
Updated•6 years ago
|
Attachment #9063074 -
Attachment is obsolete: true
Assignee | ||
Comment 3•6 years ago
|
||
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48edd877bde3
ThinArc should use NonNull. r=bholley
Pushed by ealvarez@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/63d77dbcfda8
Use PhantomData<T> in servo_arc. r=bholley
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/48edd877bde3
https://hg.mozilla.org/mozilla-central/rev/63d77dbcfda8
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•