Phabricator URL: https://phabricator.services.mozilla.com/D26233#inline-174985
Coverity helpfully left an automated review comment on a phabricator revision I pushed, "Dereferencing "bo", which is known to be "nullptr". The "bo" it's referring to is in MediaCache::InsertReadaheadBlock(, plus one more in MediaCache::NoteSeek.
There are two problems with these automated comments:
- "bo" is not known to be null here. It is asserted that it's not null on the line above, though I'd not judge the machine too harsely on this, as it's by no means a guarantee. Does coverity expect every single pointer deref to be preceeded by a null check?
- My commit didn't change this line of code. This is the more important point I think. Why is my commit having problems pre-existing in the code assigned to my commit? Only problems which my commits are introducing should invoke lint comments.