Closed Bug 1549626 Opened 2 years ago Closed 2 years ago

Fallback to basic colour contrast calculation algorithm when canvas one fails.

Categories

(DevTools :: Accessibility Tools, enhancement)

enhancement
Not set
normal

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: yzen, Assigned: yzen)

References

Details

(Whiteboard: [good first verify])

Attachments

(1 file)

We'd want to fallback on the original (most used) contrast calculation algorithm that tries to figure out the background colour of the element directly (or from its ancestry).

Assignee: nobody → yzenevich
Status: NEW → ASSIGNED

STR:

  1. Go to https://www.reddit.com/r/aww/comments/bkicxb/subreddit_of_the_week_rcatbun/ (make sure you're logged in)
  2. Inspect the "What are your thoughts?" placeholder text in the input field using the Accessibility picker tool.

ER:
A color and contrast score for the inspected text should be shown in the accessible highlighter info-bar and in the Accessibility Inspector side panel.

AR:
A message saying "Contrast: Unable to calculate" even though the inspected accessible is text.

Also for the opacity fix:

STR:

  • go to about:welcome
  • hover over the text under the email input field

ER: at the time of the this comment the values are https://contrast-ratio.com/#rgba%28255%2C%20255%2C%20255%2C%200.7%29-on-%23352f6d

AR: without the patch the values are higher because the opacity is dismissed.

Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/3bf1f379d77e
fix an issue with incorrect text colour blending. Fallback on basic colour contrast algorythm when canvas approach fails. r=mtigley
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
QA Whiteboard: [good first verify]
Whiteboard: [good first verify]
You need to log in before you can comment on or make changes to this bug.