Lots of jit-tests failed on mips
Categories
(Core :: JavaScript Engine: JIT, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: yuyin-hf, Assigned: yuyin-hf)
Details
Attachments
(4 files, 1 obsolete file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_14_4) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/12.1 Safari/605.1.15
Steps to reproduce:
get the code from hg.
build js on mips platform.
run jit-tests
Actual results:
lots of tests failed.
Expected results:
all pass
with these 4 patches, on my machines(loongson3a3000, fedora28, mips64el):
failed tests:
wasm/conversion.js
wasm/globals.js
wasm/memory.js
wasm/nan-semantics.js
wasm/spec/conversions.wast.js
wasm/spec/f32.wast.js
wasm/spec/f32_bitwise.wast.js
wasm/spec/f64.wast.js
wasm/spec/f64_bitwise.wast.js
wasm/spec/float_exprs.wast.js
wasm/spec/float_misc.wast.js
wasm/spec/local_tee.wast.js
timeout:
wasm/atomicity.js
all failed tests looks like is the qnan/snan issue:
https://sourceware.org/binutils/docs/as/MIPS-NaN-Encodings.html
can you help to review the patch and merge it to the repository？
Thank you.
|
||
Updated•5 years ago
|
|
||
Comment 7•5 years ago
|
||
Yuyin in what order do these patches need to be imported?
I get:
mozilla@ubuntu ~/mozilla-unified autoland(0) $ arc patch D30165 --nobranch
This diff is against commit 30b2b6d580a9754fb40c98a1f5306a3ee325236f, but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (.) [Y/n] n
Usage Exception: User aborted the workflow.
mozilla@ubuntu ~/mozilla-unified autoland(0) $ arc patch D30337 --nobranch
This diff is against commit 5cd96194a7826c2916819cbe761a88cc16294cad, but
the commit is nowhere in the working copy. Try to apply it against the
current working copy state? (.) [Y/n] n
Usage Exception: User aborted the workflow.
sorry for the late reply, I am on a business trip yesterday.
these patches order is from D30165 to D30337 on my local branch.
when you exec "arc patch D30165 --nobranch", there is a error about "30b2b6d580a97", this commit is merged by "https://bugzilla.mozilla.org/show_bug.cgi?id=1549278", did you run arc patch before that bug landed?
so can you try it again, thank you.
(I am not familar with hg & arc, so maybe still has issues when landed:(, but these four patched are not unrelated to each other, so they can be landed in any order)
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b661a2bf1626 [mips] Add function cmp32Move{32,ptr}. https://hg.mozilla.org/integration/autoland/rev/5d580fa5d753 [mips64] Adding missing 'breaks' to 'switch' statements. https://hg.mozilla.org/integration/autoland/rev/acf19aefc4d2 [mips] skip tests which need --spectre-XXX on. https://hg.mozilla.org/integration/autoland/rev/b0a2912f83a9 [mips] Fix unaligned load with sign/zero extend.
|
||
Comment 10•5 years ago
|
||
Backout by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d4a9de6a57b7 Backed out 4 changesets for missing reviewers. CLOSED TREE
|
|
||
Comment 11•5 years ago
|
||
Pushed by ncsoregi@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9321de819181 [mips] Add function cmp32Move{32,ptr}. r=jandem https://hg.mozilla.org/integration/autoland/rev/e8aa696bdf81 [mips64] Adding missing 'breaks' to 'switch' statements. r=jandem https://hg.mozilla.org/integration/autoland/rev/3c7878ad3840 [mips] skip tests which need --spectre-XXX on. r=jandem https://hg.mozilla.org/integration/autoland/rev/2b44ebc6ee17 [mips] Fix unaligned load with sign/zero extend. r=lth
|
||
Comment 12•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/9321de819181
https://hg.mozilla.org/mozilla-central/rev/e8aa696bdf81
https://hg.mozilla.org/mozilla-central/rev/3c7878ad3840
https://hg.mozilla.org/mozilla-central/rev/2b44ebc6ee17
|
||
Updated•5 years ago
|
Description
•