1549687 - Firefox 66: Focus not Always Placed on Most Recent Download in Downloads List when Invoked from within Private Browsing

Status: NEW

(Firefox :: Downloads Panel, defect, P3)

Description

[elliottabarnes]

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce:

Tested with Firefox 66.0.4 on both Windows 7 and 10 X64.

As of Firefox 66, I've noticed that when opening the Downloads window from within Private Browsing that focus doesn't always get automatically focused on the Downloads window. I am using the NVDA screen reader, and in previous browser builds was able to simply hit Ctrl + J from within a Private Browsing window to open my Downloads list - focus would then automatically be placed on the most recent download in the list, and NVDA would then automatically begin to output the download progress. As of version 66, however, when hitting Ctrl + J from within a Private Browsing window the Downloads window is opened, but focus isn't always placed on the most recent download in the list. To place focus on the first download, I can either hit Tab and then Shift + Tab, or use my down cursor and then my up cursor to go back to the download that I'm interested in.

Actual results:

Focus isn't always automatically placed on the most recent download in the list.

Expected results:

As with previous browser versions, focus should automatically be placed on the most recent download in the list when the Downloads window is opened.

Comment 1

[Hani Yacoub, Desktop QA]

Could you please try to reproduce the issue using the latest Firefox Nightly? You can download it from here: https://nightly.mozilla.org/

And please test the issue using a new profile, you have the steps here: https://support.mozilla.org/en-US/kb/profile-manager-create-and-remove-firefox-profiles?redirectlocale=en-US&redirectslug=Managing-profiles#w_starting-the-profile-manager

Thanks.

Comment 2

[elliottabarnes]

This is reproduceable on multiple different machines - running both Windows 7 and 10. I've also tested this with a new profile on 67 - this still happens.

Comment 3

[Hani Yacoub, Desktop QA]

I couldn't reproduce the issue, I tried to reproduce it on Firefox Nightly 69.0a1 (2019-05-26) and on Firefox 67.0.

I am going to assign the "Firefox: Downloads Panel" component for it and hopefully someone with more knowledge in this area will a look over this.

Comment 4

[:Gijs (he/him)]

Needinfo Marco and Jamie to see if they can reproduce some of this. This is likely a regression from bug 1472558, but that doesn't necessarily clarify what the problem is...

Comment 5

[Marco Bonardo [:mak]]

I could reproduce the bug in Firefox 67, it happens intermittently (just keep pressing ctrl+J and closing the tab), no errors are emitted.
Though, with the same exact steps, I could not reproduce the problem in Nightly; it's possible something else resolved the problem.

Comment 6

[Marco Bonardo [:mak]]

With these STR it should be possible to find a regression window and a fix window:

1. download 2 files (can use https://www.thinkbroadband.com/download)
2. CTRL+J
3. check first element is focused
4. if it's focused, close the downloads tab and restart from 2

P3 for now since it is apparently working correctly in the newer version, can re-evaluate if someone can reproduce in newer versions.

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Hello

Here is the range containing the fix:
First good revision: e09471d136599b68f40f6bb9ec7fcc419732948e (2019-05-30)
Last bad revision: 9131063a5ce0676336736f15d01bb5d9a2b9ad32 (2019-05-29)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=9131063a5ce0676336736f15d01bb5d9a2b9ad32&tochange=e09471d136599b68f40f6bb9ec7fcc419732948e

And here is the regression range:
Last good revision: 4cfb674227051e22bab651e5759f3de503a50560 (2017-08-04)
First bad revision: 933a04a91ce3bd44b230937083a835cb60637084 (2017-08-05)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4cfb674227051e22bab651e5759f3de503a50560&tochange=933a04a91ce3bd44b230937083a835cb60637084

I have to mention that the issue is really hard to reproduce on older versions. I hope that the regression ranges provided are accurate due to the fact that the issue is intermittent. Thank you! The regression was made using Windows 10x64.

Comment 8

[James Teh [:Jamie] (away returning 28 Jan)]

I couldn't reproduce this with a quick test on Nightly.

Comment 9

[elliottabarnes]

Just a small update on this:

As of Firefox 70.0.1, behaviour appears to have somewhat changed. When invoking the Downloads window from within a Private Browsing session with NVDA active, I have observed the following:

1. Sometimes, focus will automatically be placed on the most recent download in the list and NVDA automatically reads progress as the file downloads

2. Occasionally, as before, focus isn't placed on a download at all - the list has to manually be navigated around to get the status of the most recent download

3. Finally - in certain random situations, I've also seen NVDA be unable to read the most recent download whatsoever - when using the up/down arrows, it will simply read a part of the filename, but no status information whatsoever