1549688 - Can't remove bookmarks over urlbar if browser.newtabpage.activity-stream.feeds.asrouterfeed; false

Status: VERIFIED FIXED

(Firefox :: New Tab Page, defect, P1)

Description

[John]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. Create new profile.
2. Set browser.newtabpage.activity-stream.feeds.asrouterfeed; false on about:config page.
3. Open any bookmark and click on star in urlbar.

Actual results:

TypeError: this._handleMessageRequest is not a functionBookmarkPanelHub.jsm:63:33

Comment 1

[John]

Regression window: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=f91e832b07177b1e0a443ceee9ce4d523c5b5110&tochange=a47ffeaa2467cf4a927fc0bc225b2b7f2f6911f4

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/5038

Comment 3

[Soothsayer]

This bug appears to cause other breakages (e.g. unable to move bookmarks) in the bookmarks functionality as well.

As an example of being unable to move bookmartks with this parameter set to false:

• Go to any web page
• Bookmark it

Expected results:

• You should get a popup asking where to store the bookmark, what to call it etc.
• Change details and needed and select 'Done'
• You can then go into the library and move the bookmark to another folder, if required

Actual results:

• There is no popup and the bookmark gets placed in the 'Other Bookmarks' folder
• If you go to the library to try and move the bookmark to the correct folder, you are not able to do so until after you have restarted the browser.

Comment 4

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/f78634b8bff9

Comment 5

[Ciprian Muresan [:cmuresan], Formerly of Ecosystem QA - please needinfo @mcoman for things regarding the team]

I have verified that the issue is no longer reproducible on the latest Firefox Nightly 68.0a1 (Build ID 20190519213707) on Windows 10, macOS 10.14, and Arch Linux 4.14.3.