1549708 - Implement Page.reload's ignoreCache argument

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

In bug 1544445 I introduced minimal support for Page.reload.
But Page.reload supports two option arguments, including ignoreCache:
https://chromedevtools.github.io/devtools-protocol/tot/Page#method-reload
Page.reload:
Reloads given page optionally ignoring the cache.

• ignoreCache
  boolean If true, browser cache is ignored (as if the user pressed Shift+refresh).

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Why is this implementation blocked on my patch for bug 1589625?

Comment 2

[Andreas Tolfsen ❲:ato❳]

Because it cleans up tabs in a more generic way than could be implemented here.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sure, but what's unclear is why the dependency has been added a day after it actually was been landed. It's basically no blocker given that the feature is already available on central. I will remove the dependency.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Note that Page.reload in Puppeteer is called without any argument. So this is not blocking the alpha release.

Comment 5

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1549708: remote: implement Page.reload's ignoreCache argument;

Comment 6

[Andreas Tolfsen ❲:ato❳]

Attachment: bug 1549708: docshell: add nsIDocShell.isForceReloading;

Exposes a new nsIDocShell API, isForceReloading, to determine if
the loaded document was force-reloaded or not.

It relies on the underlying behaviour of nsDocShell::IsForceReloading(),
which again relies on nsDocShell::IsForceReloadType(mLoadType).

The getter is used in the remote agent to test that
Page.reload({ignoreCache: true}) works as intended.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Why is this blocking the alpha release? I cannot see that Puppeteer is sending parameters at all. See also my comment 4.

https://github.com/GoogleChrome/puppeteer/blob/master/lib/Page.js#L678-L688

Also Gutenberg doesn't make use of it.

Comment 8

[Andreas Tolfsen ❲:ato❳]

I had this patch lying around and I want it to be part of this milestone
so it doesn’t degrade beyond repair.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ece31d77808b
docshell: add nsIDocShell.isForceReloading; r=bzbarsky
https://hg.mozilla.org/integration/autoland/rev/ad943fb7937e
remote: implement Page.reload's ignoreCache argument; r=remote-protocol-reviewers,whimboo

Comment 10

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/ece31d77808b
https://hg.mozilla.org/mozilla-central/rev/ad943fb7937e