1549722 - The hover effect of the buttons from the first run cards is barely noticeable on Dark Theme

Status: VERIFIED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Ciprian Muresan [:cmuresan], Ecosystem QA]

[Affected versions]:

• Firefox Nightly 68.0a1, Build ID 20190507094727

[Affected Platforms]:

• All Windows
• All Mac

[Prerequisites]:

• Have the System's dark theme enabled.

[Steps to reproduce]:

1. Start the browser with a new profile and navigate to about:welcome.
2. Dismiss the modal.
3. Hover one of the buttons from the first run's cards and observe the behavior.

[Expected results]:

• The hover effect is as noticeable as it is on the Default or Light themes.

[Actual results]:

• The hover effect is barely noticeable.

[Notes]:

• The issue is also reproducible on Linux but given that the System's dark theme is not automatically applied to Firefox, there is a small chance this bug will be encountered on this platform.
• Attached a screen recording of the issue: Link.

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Aaron says to bump the opacity up a bit more on hover and active.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4989

Comment 3

[Ed Lee :Mardak]

https://hg.mozilla.org/mozilla-central/rev/690025a0dcd5

Comment 4

[Marius Coman [:mcoman], Ecosystem QA]

I have verified that this issue is no longer reproducible with the latest Firefox Nightly (68.0a1 Build ID - 20190509033505) installed, on Windows 10 x64, Arch Linux and Mac 10.13.3. Now, the hover effect of the buttons is noticeable on Dark Theme.

Comment 5

[Ed Lee :Mardak]

Marking verified as per bug 1550098 Comment 13 for bugs that were status-firefox68=verified