1549757 - Lando should default to landing patches on `default` rather than unconditionally on `tip`

Status: VERIFIED FIXED

(Conduit Graveyard :: Transplant, defect, P2)

Description

[J.C. Jones [:jcj] (he/him)]

https://lando.services.mozilla.com/D25880/ is a landing job that successfully landed an NSPR patch.
The Phab review, https://phabricator.services.mozilla.com/D25880, shows it’s going to NSPR on default... Good, good. However, Lando put the patch on a version branch, not default: https://hg.mozilla.org/projects/nspr/rev/3262b1497babd06aa111be048ff514092c2d6f87

From :smacleod, this is "due to the old part of MozReview we're using: https://github.com/mozilla-conduit/autoland-transplant/blob/master/autoland/transplant.py#L187" always landing on tip, and for NSPR tip was not default.

NSS can also have this problem, since NSS uses version branches.

Comment 1

[:glob ✱]

Attachment: Bug 1549757 - Lando should default to landing patches on `default` rather than unconditionally on `tip` r=smacleod

On repositories where there are multiple branches, tip might point to
a HEAD on a non-default branch.

Use the remote revset default instead of tip, and rename
remote_tip to target_cset for clarity.

Comment 2

[:glob ✱]

https://github.com/mozilla-conduit/autoland-transplant/commit/98e25096cfddc56acbd46a447e2e4c9f6c9afa06

Comment 3

[J.C. Jones [:jcj] (he/him)]

This happened again.

https://hg.mozilla.org/projects/nss/rev/3c2aceba7ae8

from

https://lando.services.mozilla.com/D32067/

Does something need to be deployed?

Comment 4

[J.C. Jones [:jcj] (he/him)]

Another misland of https://hg.mozilla.org/projects/nss/rev/da87cd7622ee673cb09ae234e4a4d41400c6c324 for bug 1557264.

we'll need to just stop using Lando until this is fixed.

Comment 5

[:glob ✱]

sorry about that - this has been deployed.

Comment 6

[J.C. Jones [:jcj] (he/him)]

Verified, landing https://hg.mozilla.org/projects/nss/rev/042a1d3e1161 immediately after a branch land of https://hg.mozilla.org/projects/nss/rev/189819ec6093.

Thansk!