Closed Bug 1549758 Opened 3 years ago Closed 3 years ago

Revert column number dimension to "code units", not "code points", for FF68 Beta/Release


(Core :: JavaScript Engine, task, P1)




Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 + fixed


(Reporter: tcampbell, Assigned: Waldo)





(1 file)

Due to a few lingering perf issues, we should disable the UTF-8 column fix before FF68 merges.

One option might be to revert the following two patches:
This is the ifdef that switches to the slow mode, and reverts a conversion to using UTF-8 so that is isn't plagued by colno errors.

Jeff may have some other ideas on what the best approach to achieve this is.

Summary: Disable UTF-8 parser for FF68 Beta/Release → Revert column number dimension to "code units", not "code points", for FF68 Beta/Release

This patch also reverts the function of JS::Evaluate to inflate as it did before, to fully undo the effect of the last landing in bug 1504947, and it adds a new JS::EvaluateDontInflate that does the UTF-8-aware tokenizing JS::Evaluate that processes as UTF-8 currently does. There are no callers of the new function; I figure they can be added just like for all the other compilation APIs when needed.

Builds from the try-rev above should be suitable for testing to verify that the various perf regresions are gone.

Pushed by
Revert column-number counts to counts of code units for release-or-beta, pending perf considerations in column-number counting being fixed.  r=tcampbell
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.