Closed Bug 1549771 Opened 5 years ago Closed 5 years ago

Nightly starts with add-ons enabled but most are not initialized

Categories

(Toolkit :: Add-ons Manager, defect)

defect
Not set
normal

Tracking

()

RESOLVED INCOMPLETE

People

(Reporter: bugzilla, Unassigned)

Details

Anybody who is also experiencing this and would like to comment should include output from their browser console!

Build 20190507094727, Win64

Once updating to Today's Nightly, all of my addons were missing from my toolbar except for HTTPS Everywhere. When I checked about:addons, they were all present and enabled.

The affected addons clearly had not been initialized, as one of them was uBlock Origin and I was seeing ads in content left and right.

This continued even after restarting.

Cycling each addon through Disable -> Enable has fixed the problem, including after restart.

Sorry, I did not check the browser console before restarting, so my console dump was lost.

On Slack I asked why HTTPS Everywhere would be unaffected. The only thing that Rob saw was that it was the final entry in my extensions.json.

Anybody who is also experiencing this and would like to comment should include output from their browser console!

(I would have asked if bug 1549595 comment 10 + bug 1549595 comment 11 could be related, but your build already includes the second schema bump: https://hg.mozilla.org/mozilla-central/rev/d5a6ca2d0e9d)

Unfortunately I neglected to screenshot my console but I was similarly affected by this yesterday.

I remedied the issue in the same manner as described above.

The only broken functionality that I noticed were missing icons on the toolbar and that Stylus and Snoozetabs failed to function as intended.

Seen also on 67 beta and on 66.0.5.

In the latter case, the user was able to offer console output:

Error while loading 'jar:file:///C:/Users/Me/AppData/Roaming/Mozilla/Firefox/Profiles/myprofileid.default/extensions/CookieAutoDelete@kennydo.com.xpi!/manifest.json' (NS_ERROR_FILE_CORRUPTED) Extension.jsm:452
1558116714858 addons.xpi WARN Exception running bootstrap method startup on CookieAutoDelete@kennydo.com: Error: Error while loading 'jar:file:///C:/Users/Me/AppData/Roaming/Mozilla/Firefox/Profiles/myprofileid.default/extensions/CookieAutoDelete@kennydo.com.xpi!/manifest.json' (NS_ERROR_FILE_CORRUPTED)(resource://gre/modules/Extension.jsm:452:18) JS Stack trace: readJSON/</<@Extension.jsm:452:18
onStopRequest@NetUtil.jsm:123:17
Error while loading 'jar:file:///C:/Users/Me/AppData/Roaming/Mozilla/Firefox/Profiles/myprofileid.default/extensions/https-everywhere-eff@eff.org.xpi!/manifest.json' (NS_ERROR_FILE_CORRUPTED) Extension.jsm:452
1558116714859 addons.xpi WARN Exception running bootstrap method startup on https-everywhere-eff@eff.org: Error: Error while loading 'jar:file:///C:/Users/Me/AppData/Roaming/Mozilla/Firefox/Profiles/myprofileid.default/extensions/https-everywhere-eff@eff.org.xpi!/manifest.json' (NS_ERROR_FILE_CORRUPTED)(resource://gre/modules/Extension.jsm:452:18) JS Stack trace: readJSON/</<@Extension.jsm:452:18
onStopRequest@NetUtil.jsm:123:17
Error while loading 'jar:file:///C:/Users/Me/AppData/Roaming/Mozilla/Firefox/Profiles/myprofileid.default/extensions/keepassxc-browser@keepassxc.org.xpi!/manifest.json' (NS_ERROR_FILE_CORRUPTED) Extension.jsm:452
1558116714860 addons.xpi WARN Exception running bootstrap method startup on keepassxc-browser@keepassxc.org: Error: Error while loading 'jar:file:///C:/Users/Me/AppData/Roaming/Mozilla/Firefox/Profiles/myprofileid.default/extensions/keepassxc-browser@keepassxc.org.xpi!/manifest.json' (NS_ERROR_FILE_CORRUPTED)(resource://gre/modules/Extension.jsm:452:18) JS Stack trace: readJSON/</<@Extension.jsm:452:18
onStopRequest@NetUtil.jsm:123:17
Error while loading 'jar:file:///C:/Users/Me/AppData/Roaming/Mozilla/Firefox/Profiles/myprofileid.default/extensions/savepage-we@DW-dev.xpi!/manifest.json' (NS_ERROR_FILE_CORRUPTED) Extension.jsm:452
1558116714861 addons.xpi WARN Exception running bootstrap method startup on savepage-we@DW-dev: Error: Error while loading 'jar:file:///C:/Users/Me/AppData/Roaming/Mozilla/Firefox/Profiles/myprofileid.default/extensions/savepage-we@DW-dev.xpi!/manifest.json' (NS_ERROR_FILE_CORRUPTED)(resource://gre/modules/Extension.jsm:452:18) JS Stack trace: readJSON/</<@Extension.jsm:452:18
onStopRequest@NetUtil.jsm:123:17
UpdateUtils.getAppUpdateAutoEnabled - Unable to read app update configuration file. Exception: Win error 2 during operation open on file C:\ProgramData\Mozilla\updates\308046B0AF4A39CB\update-config.json (The system cannot find the file specified.

) UpdateUtils.jsm:180
WebExtensions: new intermediate certificate added api.js:32
1558116718257 addons.xpi-utils ERROR XPI_verifySignature: [Exception... "Component returned failure code: 0x8052000b (NS_ERROR_FILE_CORRUPTED) [nsIZipReader.open]" nsresult: "0x8052000b (NS_ERROR_FILE_CORRUPTED)" location: "JS frame :: resource://gre/modules/addons/XPIInstall.jsm :: XPIPackage :: line 295" data: no] Log.jsm:679
WebExtensions: signatures re-verified api.js:42
Log warning: The log 'Services.Common.RESTRequest' is configured to use the preference 'services.common.log.logger.rest.request' - you must adjust the level by setting this preference, not by using the level setter
Flags: needinfo?(rob)

So loading jar uris to get individual files out of the extension is throwing NS_ERROR_FILE_CORRUPTED exceptions.
Is it possible to get one or more of the xpi files mentioned in the log from the affected user?

Flags: needinfo?(aklotz)

We cannot get the xpis, since the user had re-installed the add-ons
They also said:

Merely uninstalling it and then undoing that via the link Firefox conveniently provides didn't fix the problem.

Since the original report (and also the "67 beta" report) claimed that disabling and re-enabling the add-ons fixed the issue, the "66.0.5" report might have a different cause.

Regardless of the cause, we do end up in a state where the UI doesn't indicate anything wrong with the add-ons, despite them not loading. While we may not know the root cause for being in this state, we could try to account for this state (by simulating corrupted xpis) and notify the user in the UI to reduce confusion.

Flags: needinfo?(rob)
Flags: needinfo?(aklotz)

The priority flag is not set for this bug.
:ddurst, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(ddurst)

I'm closing this as incomplete. If we somehow get more information about this, please add and re-open.

Status: NEW → RESOLVED
Closed: 5 years ago
Flags: needinfo?(ddurst)
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.