1549786 - Reload the page when calling Page.navigate with the current document URI

Status: RESOLVED FIXED

(Remote Protocol :: CDP, enhancement, P1)

Description

[Alexandre Poirot [:ochameau]]

This behavior is expected when running the wordpress test suite.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Bug 1549786 - Reload when passing the existing document URL to Page.navigate.

Comment 2

[Julian Descottes [:jdescottes]]

Alex, I started adding a test case for this, but locally it passes just fine without any implementation change. Is there another test case I can use to check the issue? You can see my test at: https://hg.mozilla.org/try/rev/7adf3dcf5f96dbaf5a29dbed42aff1e9df1ab3cb

Comment 3

[Alexandre Poirot [:ochameau]]

The test case was a Gutenberg test (packages/e2e-tests/specs/preferences.test.js). When I opened this bug, the page wasn't reloading, or I wasn't receiving all the expected Page/Runtime events. Bug 1548102 may have fixed that...

I confirm what you are seeing and this implementation change is no longer necessary. The Gutenberg test now pass without this "fix".

Anyway, the added test is still useful to ensure that we do not regress that, as it was important for the gutenberg test to pass!

Comment 4

[Julian Descottes [:jdescottes]]

Attachment: Bug 1549786 - Add test for Page.navigate reloads the page with the same URL

Comment 5

[Julian Descottes [:jdescottes]]

Thanks for the feedback!
As discussed, here is a patch for the updated test. I kept the implementation as is, but if you think we don't need the complexity of checking that the page was reloading by checking the content (ie, if we can rely on the events only), I will be happy to update it to only test that the events are triggered as expected when we call the navigate API.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/65de6e306adb
Add test for Page.navigate reloads the page with the same URL r=ochameau

Comment 7

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/65de6e306adb