block code should use gNoisyMaxElementSize instead of NOISY_MAX_ELEMENTSIZE

RESOLVED FIXED

Status

()

Core
Layout
RESOLVED FIXED
16 years ago
16 years ago

People

(Reporter: Bernd, Assigned: Bernd)

Tracking

Trunk
x86
Windows 98
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

10.91 KB, patch
karnaze (gone)
: review+
Chris Waterson
: superreview+
Details | Diff | Splinter Review
(Assignee)

Description

16 years ago
Chris Waterson implemented that nice a nifty block reflow debug code which works
great with 
set GECKO_BLOCK_DEBUG_FLAGS=reflow
the sources at 
http://lxr.mozilla.org/seamonkey/source/layout/html/base/src/nsBlockFrame.cpp#93
indicate that one could also use 
set GECKO_BLOCK_DEBUG_FLAGS=max-element-size
This would be very useful but all MES debug messages in the block code are
encapsulated within a #ifdef NOISY_MAX_ELEMENTSIZE , so my proposal is to
replace these #ifdef's with: 
#ifdef DEBUG
  if(gNoisyMaxElementSize) {
   message goes here
  }
#endif
(Assignee)

Comment 1

16 years ago
mine
Assignee: attinasi → bernd.mielke
Summary: block code should use gNoisyMaxElementSize instead of NOISY_MAX_ELEMENTSIZE → block code should use gNoisyMaxElementSize instead of NOISY_MAX_ELEMENTSIZE
(Assignee)

Comment 2

16 years ago
Created attachment 89723 [details] [diff] [review]
patch

attachment 89271 [details] shows a example of the patch
(Assignee)

Comment 3

16 years ago
em, I meant attachment 89721 [details] - to much french red wine

Comment 4

16 years ago
Comment on attachment 89723 [details] [diff] [review]
patch

sr=waterson
Attachment #89723 - Flags: superreview+

Comment 5

16 years ago
Comment on attachment 89723 [details] [diff] [review]
patch

r=karnaze
Attachment #89723 - Flags: review+
(Assignee)

Comment 6

16 years ago
fix checked in
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.