Closed Bug 1549797 Opened 1 year ago Closed 1 year ago

Remove unnecessary blocklist hooks from TestDllBlocklist

Categories

(Core :: mozglue, task, P1)

Unspecified
Windows
task

Tracking

()

RESOLVED FIXED
mozilla69
Tracking Status
firefox68 --- fixed
firefox69 --- fixed

People

(Reporter: aklotz, Assigned: aklotz)

Details

Attachments

(1 file)

There's a bunch of stuff being built into mozglue blocklist code that shouldn't be there for builds that we ship.

Summary: Move blocklist gtest code to a dedicated library → Move blocklist gtest code to a cppunittest
Priority: P2 → P1
Summary: Move blocklist gtest code to a cppunittest → Remove unnecessary blocklist hooks from TestDllBlocklist

We remove the debugging hooks that were added to check to see whether a DLL
was loaded, as we can just as easily check that by querying the loader itself.
Plus, we shouldn't be exporting a bunch of test-only loader hooks from mozglue
in our release builds, which is what we are currently doing.

We also remove Injector, InjectorDLL, and TestDLLEject, as these tests can
just as easily be done from within TestDllBlocklist by creating a thread with
LoadLibrary* as the entry point. The CreateRemoteThread stuff, while a more
accurate simulation, has no material effect on whether or not the thread
blocking code works.

Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2e575eb46c42
Remove loader hooks for TestDllBlocklist from mozglue; r=mhowell
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla69

Comment on attachment 9071138 [details]
Bug 1549797: Remove loader hooks for TestDllBlocklist from mozglue; r=mhowell!

Beta/Release Uplift Approval Request

  • User impact if declined: Binaries will contain unnecessary test code that could be abused by third-party software.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): It's entirely test code, but it affects mozglue.dll in the build, so I'm requesting approval.
  • String changes made/needed:
Attachment #9071138 - Flags: approval-mozilla-beta?

Comment on attachment 9071138 [details]
Bug 1549797: Remove loader hooks for TestDllBlocklist from mozglue; r=mhowell!

approved for 68.0b10

Attachment #9071138 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.