Remove unnecessary blocklist hooks from TestDllBlocklist
Categories
(Core :: mozglue, task, P1)
Tracking
()
People
(Reporter: bugzilla, Assigned: bugzilla)
Details
Attachments
(1 file)
47 bytes,
text/x-phabricator-request
|
jcristau
:
approval-mozilla-beta+
|
Details | Review |
There's a bunch of stuff being built into mozglue blocklist code that shouldn't be there for builds that we ship.
Assignee | ||
Comment 1•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8ceae2f8b5d88c595e44471141aa86ae8b431e2c
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 2•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fdffbfcf1bf07f1d05e45c5a3b64169ad5af9bb9
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 3•5 years ago
|
||
We remove the debugging hooks that were added to check to see whether a DLL
was loaded, as we can just as easily check that by querying the loader itself.
Plus, we shouldn't be exporting a bunch of test-only loader hooks from mozglue
in our release builds, which is what we are currently doing.
We also remove Injector, InjectorDLL, and TestDLLEject, as these tests can
just as easily be done from within TestDllBlocklist by creating a thread with
LoadLibrary* as the entry point. The CreateRemoteThread stuff, while a more
accurate simulation, has no material effect on whether or not the thread
blocking code works.
Pushed by aklotz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e575eb46c42 Remove loader hooks for TestDllBlocklist from mozglue; r=mhowell
Comment 5•5 years ago
|
||
bugherder |
Assignee | ||
Comment 6•5 years ago
|
||
Comment on attachment 9071138 [details]
Bug 1549797: Remove loader hooks for TestDllBlocklist from mozglue; r=mhowell!
Beta/Release Uplift Approval Request
- User impact if declined: Binaries will contain unnecessary test code that could be abused by third-party software.
- Is this code covered by automated tests?: Yes
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's entirely test code, but it affects mozglue.dll in the build, so I'm requesting approval.
- String changes made/needed:
Comment 7•5 years ago
|
||
Comment on attachment 9071138 [details]
Bug 1549797: Remove loader hooks for TestDllBlocklist from mozglue; r=mhowell!
approved for 68.0b10
Comment 8•5 years ago
|
||
bugherder uplift |
Description
•