1549803 - Complete CustomElement for LoginListItem

Status: RESOLVED FIXED

(Firefox :: about:logins, enhancement, P1)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

The LoginListItem custom element is used to display a single login within the LoginList custom element. The login item should show the hostname and username. Clicking on the login item should dispatch an event that the LoginItem custom element can listen for.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549803 - Add a reference to the common.css stylesheet. r?MattN

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549803 - Change LoginList to use an OL instead of PRE for containing the LoginListItems. r?MattN

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549803 - Add a check that the remoteType is privileged. r?MattN

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549803 - Move styling of LoginListItem to an external stylesheet. r?MattN

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549803 - Move the handling of the selected login list item to the login list. r?MattN

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2d13d407f562
Add a reference to the common.css stylesheet. r=MattN
https://hg.mozilla.org/integration/autoland/rev/e062410531b1
Change LoginList to use an OL instead of PRE for containing the LoginListItems. r=MattN
https://hg.mozilla.org/integration/autoland/rev/e450e9d4671c
Add a check that the remoteType is privileged. r=MattN
https://hg.mozilla.org/integration/autoland/rev/452720b78ca7
Move styling of LoginListItem to an external stylesheet. r=MattN
https://hg.mozilla.org/integration/autoland/rev/7e08cf4753a7
Move the handling of the selected login list item to the login list. r=MattN

Comment 8

[Daniel Varga [:dvarga]]

Backed out 8 changesets (Bug 1549803, Bug 1550095) for browser-chrome failuire at browser/components/aboutlogins/tests/browser/browser_updateLogin.js

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=245777841&revision=7e08cf4753a79d765acc9721c65104c229a3f5fd

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245853858&repo=autoland&lineNumber=3721

Backout link: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=245777841&revision=54f367c785cbd4cf3ccb3f4d1478aea7c636d6cb

[task 2019-05-10T22:15:52.235Z] 22:15:52     INFO - GECKO(2989) | console.warn: LoginHelper: "Couldn't parse origin for" "about:logins" ({})
[task 2019-05-10T22:15:52.236Z] 22:15:52     INFO - GECKO(2989) | console.warn: LoginHelper: "Couldn't parse origin for" "about:logins" ({})
[task 2019-05-10T22:15:52.257Z] 22:15:52     INFO - GECKO(2989) | JavaScript error: , line 0: uncaught exception: [fluent][resolver] errors in en-US/login-item: ReferenceError: Unknown variable: timeCreated, ReferenceError: Unknown variable: timeChanged, ReferenceError: Unknown variable: timeUsed.
[task 2019-05-10T22:15:57.426Z] 22:15:57     INFO - TEST-INFO | started process screentopng
[task 2019-05-10T22:15:57.958Z] 22:15:57     INFO - TEST-INFO | screentopng: exit 0
[task 2019-05-10T22:15:57.958Z] 22:15:57     INFO - Buffered messages logged at 22:15:51
[task 2019-05-10T22:15:57.960Z] 22:15:57     INFO - Entering test bound setup
[task 2019-05-10T22:15:57.961Z] 22:15:57     INFO - Buffered messages logged at 22:15:52
[task 2019-05-10T22:15:57.962Z] 22:15:57     INFO - Console message: [JavaScript Error: "uncaught exception: [fluent][resolver] errors in en-US/login-item: ReferenceError: Unknown variable: timeCreated, ReferenceError: Unknown variable: timeChanged, ReferenceError: Unknown variable: timeUsed."]
[task 2019-05-10T22:15:57.964Z] 22:15:57     INFO - Leaving test bound setup
[task 2019-05-10T22:15:57.965Z] 22:15:57     INFO - Entering test bound test_show_logins
[task 2019-05-10T22:15:57.966Z] 22:15:57     INFO - Buffered messages finished
[task 2019-05-10T22:15:57.969Z] 22:15:57     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_updateLogin.js | Uncaught exception - Waiting for login to be displayed - timed out after 50 tries.
[task 2019-05-10T22:15:57.970Z] 22:15:57     INFO - Leaving test bound test_show_logins
[task 2019-05-10T22:15:57.971Z] 22:15:57     INFO - Entering test bound test_login_item
[task 2019-05-10T22:15:57.971Z] 22:15:57     INFO - Not taking screenshot here: see the one that was previously logged
[task 2019-05-10T22:15:57.974Z] 22:15:57     INFO - TEST-UNEXPECTED-FAIL | browser/components/aboutlogins/tests/browser/browser_updateLogin.js | Uncaught exception - TypeError: loginListItem is null
[task 2019-05-10T22:15:57.975Z] 22:15:57     INFO - Leaving test bound test_login_item
[task 2019-05-10T22:15:57.975Z] 22:15:57     INFO - GECKO(2989) | MEMORY STAT | vsize 20974891MB | residentFast 1007MB
[task 2019-05-10T22:15:57.982Z] 22:15:57     INFO - TEST-OK | browser/components/aboutlogins/tests/browser/browser_updateLogin.js | took 5706ms
[task 2019-05-10T22:15:57.991Z] 22:15:57     INFO - checking window state
[task 2019-05-10T22:15:59.953Z] 22:15:59     INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3117
[task 2019-05-10T22:16:00.014Z] 22:16:00     INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3173
[task 2019-05-10T22:16:00.042Z] 22:16:00     INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3146
[task 2019-05-10T22:16:00.100Z] 22:16:00     INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3041
[task 2019-05-10T22:16:00.197Z] 22:16:00     INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 3062
[task 2019-05-10T22:16:00.974Z] 22:16:00     INFO - GECKO(2989) | Completed ShutdownLeaks collections in process 2989

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b665ca03d2f6
Add a reference to the common.css stylesheet. r=MattN
https://hg.mozilla.org/integration/autoland/rev/fe60f9cc2007
Change LoginList to use an OL instead of PRE for containing the LoginListItems. r=MattN
https://hg.mozilla.org/integration/autoland/rev/fe75205edc19
Add a check that the remoteType is privileged. r=MattN
https://hg.mozilla.org/integration/autoland/rev/aa8595d46694
Move styling of LoginListItem to an external stylesheet. r=MattN
https://hg.mozilla.org/integration/autoland/rev/af805180a1e6
Move the handling of the selected login list item to the login list. r=MattN

Comment 10

[Dorel Luca [:dluca]]

Backed out 8 changesets (bug 1549803, bug 1550095) for Browser-chrome failures in browser/components/aboutlogins/tests/browser/browser_updateLogin.js

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245908190&repo=autoland&lineNumber=3742

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=af805180a1e6329754d626a62d17bdca87ffc2b0

Backout:
https://hg.mozilla.org/integration/autoland/rev/1be22e2d35d1e2a40451b2d555ced98a49d533af

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/54c528ee4cc6
Add a reference to the common.css stylesheet. r=MattN
https://hg.mozilla.org/integration/autoland/rev/6efab548863e
Change LoginList to use an OL instead of PRE for containing the LoginListItems. r=MattN
https://hg.mozilla.org/integration/autoland/rev/7654f255fd12
Add a check that the remoteType is privileged. r=MattN
https://hg.mozilla.org/integration/autoland/rev/018fd8ddc657
Move styling of LoginListItem to an external stylesheet. r=MattN
https://hg.mozilla.org/integration/autoland/rev/79cb58efc5bc
Move the handling of the selected login list item to the login list. r=MattN

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/54c528ee4cc6
https://hg.mozilla.org/mozilla-central/rev/6efab548863e
https://hg.mozilla.org/mozilla-central/rev/7654f255fd12
https://hg.mozilla.org/mozilla-central/rev/018fd8ddc657
https://hg.mozilla.org/mozilla-central/rev/79cb58efc5bc