1549809 - Searching of usernames and hostnames and showing the search result count

Status: VERIFIED FIXED

(Firefox :: about:logins, enhancement, P1)

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

The search bar should be at the top of the page and will perform live updates to the list of logins displayed in the LoginList.

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549809 - Stub out LoginFilter custom element. r?MattN

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549809 - Place the elements in a grid. r?MattN

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549809 - Apply common styling to the shadow DOM. r?MattN

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549809 - Style the login-filter to span the header. r?MattN

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549809 - Live filter logins in the login list. r?MattN

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549809 - Show the count of the items in the login list. r?MattN

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549809 - Tweak the colors on the page and change to semantic CSS variable names. r?MattN

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549809 - Automated tests for filtering logins. r?MattN

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1549809 - Reduce duplication of reflected Fluent strings. r?MattN

This patch also fixes a bug where the custom elements wouldn't display their localized text if the attributes were updated before the custom element was defined.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cec13612ee6
Stub out LoginFilter custom element. r=MattN,Pike
https://hg.mozilla.org/integration/autoland/rev/a3295a88f54b
Place the elements in a grid. r=MattN
https://hg.mozilla.org/integration/autoland/rev/568b13ef38ac
Apply common styling to the shadow DOM. r=MattN
https://hg.mozilla.org/integration/autoland/rev/06466fbe6b4e
Style the login-filter to span the header. r=MattN
https://hg.mozilla.org/integration/autoland/rev/60941bb2b524
Live filter logins in the login list. r=MattN
https://hg.mozilla.org/integration/autoland/rev/bba51fabf09d
Show the count of the items in the login list. r=MattN,Pike
https://hg.mozilla.org/integration/autoland/rev/2e3ae6f6b1cf
Tweak the colors on the page and change to semantic CSS variable names. r=MattN
https://hg.mozilla.org/integration/autoland/rev/ae45390d5061
Automated tests for filtering logins. r=MattN
https://hg.mozilla.org/integration/autoland/rev/22be0302af4d
Reduce duplication of reflected Fluent strings. r=MattN,Pike

Comment 12

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/3cec13612ee6
https://hg.mozilla.org/mozilla-central/rev/a3295a88f54b
https://hg.mozilla.org/mozilla-central/rev/568b13ef38ac
https://hg.mozilla.org/mozilla-central/rev/06466fbe6b4e
https://hg.mozilla.org/mozilla-central/rev/60941bb2b524
https://hg.mozilla.org/mozilla-central/rev/bba51fabf09d
https://hg.mozilla.org/mozilla-central/rev/2e3ae6f6b1cf
https://hg.mozilla.org/mozilla-central/rev/ae45390d5061
https://hg.mozilla.org/mozilla-central/rev/22be0302af4d

Comment 13

[Timea Cernea [:tbabos][inactive]]

Verified - fixed on latest Nightly 68.0a1 (2019-05-17) (64-bit) on Windows 10 x64, Mac OS 10.14 and Ubuntu 18.04.
The search bar is displayed at the top of the page and filters the list based on the inputted username and hostname.