Closed Bug 1549828 Opened 5 months ago Closed 5 months ago

Screenshots 39.0.0 release (disable Library/My Shots)

Categories

(Firefox :: Screenshots, defect)

defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 68
Tracking Status
firefox68 --- verified

People

(Reporter: ianbicking, Assigned: ianbicking)

Details

Attachments

(2 files)

39.0.0 is only really one commit, which disables the Screenshots Library button and My Shots. Previously we checked with the server to determine if the user was a screenshots.firefox.com user, and showed those buttons conditionally on that.

This patch removes some code, but trimming out all the now-unneeded server-related code is a much larger patch for a later Firefox version.

https://github.com/mozilla-services/screenshots/blob/master/CHANGELOG.md#version-3900

Pushed by ibicking@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7e851ac3cb03
Export Screenshots 39.0.0 (translations only) r=_6a68,flod
https://hg.mozilla.org/integration/autoland/rev/d48bf099053b
Export Screenshots 39.0.0 (code excluding translations) r=_6a68
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

Hello,

I stumbled across this bug while doing the triage for Fx Beta 68. Do you think that the bug or rather some specific part of the feature related to this bug, would benefit from Manual QA testing?

Flags: qe-verify?
Flags: needinfo?(ianb)

It could have QA testing to confirm:

  1. My Shots does not appear when you take a screenshot (as a button, next to "Save full page" and "Save visible")
  2. Screenshots does not appear in the Library menu
  3. There are no warnings in the Browser Console about screenshots
Flags: needinfo?(ianb)
Flags: qe-verify? → qe-verify+

Hi,

This issue is Verified as fixed in Firefox Beta 68.0b13 and latest Nightly 69.0a1 (2019-06-27) on Windows 10, Ubuntu 18.04 and Mac Os 10.14.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.